Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies #2260

Merged
merged 3 commits into from
Mar 8, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .husky/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
_
1 change: 1 addition & 0 deletions .husky/commit-msg
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
yarn commitlint --edit $1
1 change: 1 addition & 0 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
yarn lint-staged
27 changes: 11 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,34 +18,35 @@
"test:integration": "lerna exec --scope integration-tests -- yarn sauce",
"test:performance": "lerna exec --scope perf-benchmarks -- best --runner default",
"release:publish:ci": "./scripts/release/publish.js",
"release:version": "./scripts/release/version.js"
"release:version": "./scripts/release/version.js",
"postinstall": "husky install"
Copy link
Contributor

@ravijayaramappa ravijayaramappa Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move it to “prepare” step instead of postinstall
https://github.com/typicode/husky/tree/main/docs#install

Related discussion: typicode/husky#888
typicode/husky#884

},
"devDependencies": {
"@babel/core": "^7.12.3",
"@babel/preset-env": "^7.12.11",
"@babel/preset-typescript": "^7.12.7",
"@commitlint/cli": "^11.0.0",
"@commitlint/cli": "^12.0.1",
"@rollup/plugin-replace": "^2.3.4",
"@types/acorn": "^4.0.5",
"@types/babel__core": "^7.1.12",
"@types/jest": "^26.0.20",
"@types/node": "^14.14.29",
"@typescript-eslint/eslint-plugin": "^4.15.1",
"@typescript-eslint/parser": "^4.15.1",
"@types/node": "^14.14.31",
"@typescript-eslint/eslint-plugin": "^4.16.1",
"@typescript-eslint/parser": "^4.16.1",
"babel-plugin-tester": "^10.0.0",
"concurrently": "^5.3.0",
"concurrently": "^6.0.0",
"es5-proxy-compat": "^0.22.1",
"eslint": "^7.20.0",
"eslint": "^7.21.0",
"eslint-plugin-jest": "^24.1.5",
"eslint-plugin-lwc-internal": "link:./scripts/eslint-plugin",
"execa": "^5.0.0",
"fs-extra": "^9.1.0",
"glob": "^7.1.6",
"husky": "^4.3.8",
"husky": "^5.1.3",
"is-ci": "^3.0.0",
"isbinaryfile": "^4.0.6",
"jest": "^26.6.3",
"lerna": "^3.22.1",
"lerna": "^4.0.0",
"lint-staged": "^10.5.4",
"prettier": "^2.2.1",
"rollup": "^2.38.3",
Expand All @@ -56,15 +57,9 @@
"rollup-plugin-typescript": "^1.0.1",
"semver": "^7.3.4",
"tslib": "^2.1.0",
"typescript": "^4.1.5",
"typescript": "^4.2.2",
"worker-farm": "^1.7.0"
},
"husky": {
"hooks": {
"pre-commit": "lint-staged",
"commit-msg": "commitlint -e $HUSKY_GIT_PARAMS"
}
},
"lint-staged": {
"**/*.{js,ts}": "eslint",
"{packages,scripts}/**/*.{js,ts,json,md}": "prettier --write"
Expand Down
4 changes: 2 additions & 2 deletions packages/@lwc/compiler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@
"@lwc/shared": "1.17.6",
"@lwc/style-compiler": "1.17.6",
"@lwc/template-compiler": "1.17.6",
"@rollup/plugin-replace": "~2.3.4",
"@rollup/plugin-replace": "~2.4.1",
"babel-preset-compat": "~0.22.1",
"rollup": "~2.38.3",
"terser": "~5.5.1"
"terser": "~5.6.0"
},
"devDependencies": {
"source-map": "^0.7.3"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ async function updateVersion(version) {

const result = await rollup({
input: sourcePath,
plugins: [replace({ __VERSION__: version })],
plugins: [replace({ __VERSION__: version, preventAssignment: true })],
});

await result.write({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,6 @@ export default function ({ options }: { options: NormalizedCompileOptions }): Pl

return rollupPluginReplace({
values: patterns,
preventAssignment: true,
});
}
2 changes: 1 addition & 1 deletion packages/@lwc/module-resolver/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"dist/"
],
"dependencies": {
"resolve": "~1.19.0"
"resolve": "~1.20.0"
},
"publishConfig": {
"access": "public"
Expand Down
2 changes: 1 addition & 1 deletion packages/@lwc/style-compiler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"dist/"
],
"dependencies": {
"postcss": "~8.2.4",
"postcss": "~8.2.7",
"postcss-selector-parser": "~6.0.4",
"postcss-value-parser": "~4.1.0"
},
Expand Down
16 changes: 8 additions & 8 deletions packages/integration-tests/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,17 +21,17 @@
},
"devDependencies": {
"@lwc/rollup-plugin": "1.17.6",
"@wdio/cli": "^6.12.1",
"@wdio/local-runner": "^6.12.1",
"@wdio/mocha-framework": "^6.11.0",
"@wdio/sauce-service": "^6.12.1",
"@wdio/selenium-standalone-service": "^6.12.1",
"@wdio/spec-reporter": "^6.11.0",
"@wdio/static-server-service": "^6.10.10",
"@wdio/cli": "^7.0.9",
"@wdio/local-runner": "^7.0.9",
"@wdio/mocha-framework": "^7.0.7",
"@wdio/sauce-service": "^7.0.9",
"@wdio/selenium-standalone-service": "^7.0.7",
"@wdio/spec-reporter": "^7.0.7",
"@wdio/static-server-service": "^7.0.7",
"deepmerge": "^4.2.2",
"dotenv": "^8.2.0",
"lwc": "1.17.6",
"minimist": "^1.2.5",
"webdriverio": "^6.12.1"
"webdriverio": "^7.0.9"
}
}
6 changes: 5 additions & 1 deletion packages/integration-tests/scripts/build.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,11 @@ function createRollupInputConfig() {
entryPointResolverPlugin(),
rollupLwcCompilerPlugin({ exclude: `**/*${testSufix}` }),
isCompat && rollupCompatPlugin({ polyfills: false }),
isProd && rollupReplacePlugin({ 'process.env.NODE_ENV': JSON.stringify('production') }),
isProd &&
rollupReplacePlugin({
'process.env.NODE_ENV': JSON.stringify('production'),
preventAssignment: true,
}),
].filter(Boolean),
};
}
Expand Down
6 changes: 5 additions & 1 deletion packages/lwc/scripts/utils/rollup.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ function rollupConfig(config) {
inputOptions: {
input,
plugins: [
prod && rollupReplace({ 'process.env.NODE_ENV': JSON.stringify('production') }),
prod &&
rollupReplace({
'process.env.NODE_ENV': JSON.stringify('production'),
preventAssignment: true,
}),
rollupFeaturesPlugin(prod),
compatMode && rollupTypescriptPlugin({ target, typescript, include: ['/**/*.js'] }),
prod && !debug && rollupTerser(),
Expand Down
5 changes: 4 additions & 1 deletion packages/perf-benchmarks/best.base.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ module.exports = {
exclude: ['/engine.js$/', '/@best/runtime/'],
},
],
['@rollup/plugin-replace', { 'process.env.NODE_ENV': JSON.stringify('production') }],
[
'@rollup/plugin-replace',
{ 'process.env.NODE_ENV': JSON.stringify('production'), preventAssignment: true },
],
],

benchmarkOnClient: false,
Expand Down
Loading