chore: update dependencies #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulsattar
force-pushed
the
abdulsattar/update-deps-mar4
branch
from
f2df091 to
3f32330
Compare
⚠ Performance RegressionBest has detected that there is a Please click here to see more details. Click to view significantly changed benchmarks@lwc/engine-dom
@lwc/engine-server
|
pmdartus
requested changes
Mar 8, 2021
.husky/commit-msg
Outdated
| @@ -0,0 +1,2 @@ | |||
| npx --no-install commitlint --edit $1 | |||
There was a problem hiding this comment.
This file does run twice commitlint, remove the duplicate.
Suggested change
| npx --no-install commitlint --edit $1 |
.husky/pre-commit
Outdated
| @@ -0,0 +1,2 @@ | |||
| npx --no-install lint-staged | |||
There was a problem hiding this comment.
Ditto
Suggested change
| npx --no-install lint-staged |
package.json
Outdated
| @@ -56,7 +57,7 @@ | |||
| "rollup-plugin-typescript": "^1.0.1", | |||
| "semver": "^7.3.4", | |||
| "tslib": "^2.1.0", | |||
| "typescript": "^4.1.5", | |||
| "typescript": "^4.2.2", | |||
| "worker-farm": "^1.7.0" | |||
| }, | |||
| "husky": { | |||
pmdartus
approved these changes
Mar 8, 2021
package.json
Outdated
| @@ -18,34 +18,35 @@ | |||
| "test:integration": "lerna exec --scope integration-tests -- yarn sauce", | |||
| "test:performance": "lerna exec --scope perf-benchmarks -- best --runner default", | |||
| "release:publish:ci": "./scripts/release/publish.js", | |||
| "release:version": "./scripts/release/version.js" | |||
| "release:version": "./scripts/release/version.js", | |||
| "postinstall": "husky install" | |||
There was a problem hiding this comment.
Move it to “prepare” step instead of postinstall
https://github.com/typicode/husky/tree/main/docs#install
Related discussion: typicode/husky#888
typicode/husky#884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Weekly dependency update.
Does this PR introduce breaking changes?
No, it does not introduce breaking changes.The PR fulfills these requirements:
GUS work item
W-7258582