handling a few unused variables in geometry,graphs,numerical,structure

src/sage/geometry/palp_normal_form.pyx

@@ -195,7 +195,7 @@ def _palp_PM_max(Matrix_integer_dense PM, check=False):
         else:
             S[i] = i + 1
 
-    cdef int l, np, cf, ccf, n_s_bar, d1, v0, vc, vj
+    cdef int l, cf, ccf, n_s_bar, d1, v0, vc, vj
     cdef list l_r
 
     # We determine the other rows of PM_max in turn by use of perms and

src/sage/graphs/base/static_sparse_graph.pyx

@@ -280,10 +280,9 @@
     g.m = G.size()
 
     cdef int isdigraph = G.is_directed()
-    cdef uint32_t i, v_id, j
+    cdef uint32_t i, j
     cdef list vertices = vertex_list if vertex_list is not None else list(G)
     cdef dict v_to_id = {v: i for i, v in enumerate(vertices)}
-    cdef list neighbor_label
     cdef list edge_labels
     # Loops are not stored twice for undirected graphs
     cdef int n_edges = g.m if isdigraph else 2*g.m - G.number_of_loops()
@@ -1183,7 +1182,7 @@
         sage: while not G.is_strongly_connected():
         ....:     shuffle(r)
         ....:     G.add_edges(enumerate(r), loops=False)
         sage: spectral_radius(G, 1e-10)  # random  # long time
         (1.9997956006500042, 1.9998043797692782)
 
     The algorithm takes care of multiple edges::

src/sage/graphs/traversals.pyx

@@ -471,8 +471,6 @@ def lex_BFS(G, reverse=False, tree=False, initial_vertex=None, algorithm="fast")
     if algorithm != "fast":
         raise ValueError(f"unknown algorithm '{algorithm}'")
 
-    cdef size_t n = G.order()
-
     # For algorithm "fast" we need to convert G to an undirected graph
     if G.is_directed():
         G = G.to_undirected()
@@ -485,8 +483,6 @@ def lex_BFS(G, reverse=False, tree=False, initial_vertex=None, algorithm="fast")
     # Initialize variables needed by the fast algorithm
     cdef vector[int] sigma_int
     cdef vector[int] pred
-    # Initialize variables needed by the slow algorithm
-    cdef dict lexicographic_label
     # Temporary variables
     cdef int vi, i, initial_v_int
 
@@ -497,8 +493,8 @@ def lex_BFS(G, reverse=False, tree=False, initial_vertex=None, algorithm="fast")
     else:
         initial_v_int = -1
     extended_lex_BFS(cg, sigma_int, NULL, initial_v_int, &pred, NULL, NULL)
-    sigma = [ Gbackend.vertex_label(vi) for vi in sigma_int ]
-    predecessor = { u: sigma[i] for u, i in zip(sigma, pred) if i != -1 }
+    sigma = [Gbackend.vertex_label(vi) for vi in sigma_int]
+    predecessor = {u: sigma[i] for u, i in zip(sigma, pred) if i != -1}
 
     if reverse:
         sigma.reverse()

src/sage/numerical/backends/cvxopt_backend.pyx

@@ -300,7 +300,7 @@ cdef class CVXOPTBackend(GenericBackend):
         """
         for i in range(len(coeff)):
             self.objective_function[i] = coeff[i]
-        obj_constant_term = d
+        self.obj_constant_term = d
 
     cpdef set_verbosity(self, int level):
         """

src/sage/numerical/backends/matrix_sdp_backend.pyx

@@ -242,7 +242,7 @@ cdef class MatrixSDPBackend(GenericSDPBackend):
         """
         for i in range(len(coeff)):
             self.objective_function[i] = coeff[i]
-        obj_constant_term = d
+        self.obj_constant_term = d
 
     cpdef add_linear_constraint(self, coefficients, name=None):
         """

src/sage/numerical/mip.pyx

@@ -990,7 +990,6 @@ cdef class MixedIntegerLinearProgram(SageObject):
         """
         from sage.rings.integer import Integer as Integer
         cdef int i
-        cdef str s
         cdef GenericBackend b = self._backend
 
         result = []
@@ -1005,16 +1004,15 @@ cdef class MixedIntegerLinearProgram(SageObject):
             return (lb, b.row(indices), ub)
 
         # List of constraints
-        elif isinstance(indices, list):
+        if isinstance(indices, list):
             for i in indices:
                 lb, ub = b.row_bounds(i)
                 result.append((lb, b.row(i), ub))
 
             return result
 
         # Weird Input
-        else:
-            raise ValueError("constraints() requires a list of integers, though it will accommodate None or an integer.")
+        raise ValueError("constraints() requires a list of integers, though it will accommodate None or an integer.")
 
     def polyhedron(self, **kwds):
         r"""

src/sage/numerical/sdp.pyx

@@ -656,7 +656,7 @@ cdef class SemidefiniteProgram(SageObject):
 
         ##### Constraints
         print("Constraints:")
-        for 0<= i < b.nrows():
+        for i in range(b.nrows()):
             indices, values = b.row(i)
             print(" ", end=" ")
             # Constraint's name
@@ -666,7 +666,7 @@ cdef class SemidefiniteProgram(SageObject):
             l = sorted(zip(indices,values))
             l.reverse()
             if l[-1][0] == -1:
-                last_i,last_value = l.pop()
+                _, last_value = l.pop()
             else:
                 last_value = matrix.zero( l[0][1].dimensions()[0],l[0][1].dimensions()[1]  )
             l.reverse()

src/sage/structure/coerce.pyx

@@ -1600,7 +1600,7 @@ cdef class CoercionModel:
         """
         if homs is None:
             return None
-        cdef Map x_map, y_map
+        cdef Map R_map, S_map
         R_map, S_map = homs
         if isinstance(R, type):
             R = Set_PythonType(R)

src/sage/structure/coerce_actions.pyx

@@ -759,7 +759,7 @@ cdef class IntegerMulAction(IntegerAction):
     def __init__(self, Z, M, is_left=True, m=None):
         if m is None:
             m = M.an_element()
-        test = m + (-m)  # make sure addition and negation is allowed
+        _ = m + (-m)  # make sure addition and negation is allowed
         super().__init__(Z, M, is_left, operator.mul)
 
     cpdef _act_(self, nn, a):

src/sage/structure/element.pyx

@@ -712,7 +712,6 @@ cdef class Element(SageObject):
         """
         tester = self._tester(**options)
         SageObject._test_category(self, tester=tester)
-        category = self.category()
         # Tests that self inherits methods from the categories
         if can_assign_class(self):
             # For usual Python classes, that should be done with

src/sage/structure/parent.pyx

@@ -880,7 +880,6 @@ cdef class Parent(sage.structure.category_object.CategoryObject):
         """
         if self._element_constructor is None:
             raise NotImplementedError(f"cannot construct elements of {self}")
-        cdef Py_ssize_t i
         cdef R = parent(x)
         cdef bint no_extra_args = (not args and not kwds)
         if R is self and no_extra_args:
@@ -2409,7 +2408,7 @@ cdef class Parent(sage.structure.category_object.CategoryObject):
         # setting this to 1 will make it return the first path found.
 
         cdef int mor_found = 0
-        cdef Parent R, D
+        cdef Parent D
         # Recurse.  Note that if S is the domain of one of the maps in self._coerce_from_list,
         # we will have stuck the map into _coerce_map_hash and thus returned it already.
         for mor in self._coerce_from_list: