Skip to content

handling a few unused variables in geometry,graphs,numerical,structure #39685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 22, 2025

Conversation

fchapoton
Copy link
Contributor

found using cython-lint

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit eb840a4; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It's surprising that the changes you made in src/sage/numerical/backends/cvxopt_backend.pyx and src/sage/numerical/backends/matrix_sdp_backend.pyx have not been required earlier.

@fchapoton
Copy link
Contributor Author

merci. En effet.

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 19, 2025
sagemathgh-39685: handling a few unused variables in geometry,graphs,numerical,structure
    
found using `cython-lint`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#39685
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 087ee1f into sagemath:develop Mar 22, 2025
24 checks passed
@fchapoton fchapoton deleted the some_unused_variables branch March 22, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants