Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #209: Add event for incoming eth #278

Merged
merged 3 commits into from
Mar 19, 2021

Conversation

rmeissner
Copy link
Member

@rmeissner rmeissner commented Mar 17, 2021

Closes #209

  • Added SafeReceived event
  • Change send and transfer test to expect revert

Note: This PR is based on #277

@rmeissner rmeissner force-pushed the feature/issue_209_incoming_eth_event branch from 10e7528 to a661cb2 Compare March 18, 2021 10:52
@rmeissner rmeissner marked this pull request as ready for review March 18, 2021 12:52
contracts/common/EtherPaymentFallback.sol Outdated Show resolved Hide resolved
@rmeissner rmeissner merged commit 4831c5f into development Mar 19, 2021
@rmeissner rmeissner deleted the feature/issue_209_incoming_eth_event branch March 19, 2021 09:00
Uxio0 pushed a commit that referenced this pull request May 6, 2021
Saw-mon-and-Natalie pushed a commit to Saw-mon-and-Natalie/safe-contracts that referenced this pull request Nov 1, 2023
fdarian pushed a commit to fdarian/safe-contracts that referenced this pull request Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event for incoming ether transfer
2 participants