Gas optimizations #277
Merged
Gas optimizations #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmeissner
force-pushed
the
feature/gas_refactorings
branch
from
ff7c725 to
b5b4168
Compare
Uxio0
approved these changes
Mar 17, 2021
| @@ -9,6 +9,8 @@ import "../GnosisSafe.sol"; | |||
| /// @title Compatibility Fallback Handler - fallback handler to provider compatibility between pre 1.3.0 and 1.3.0+ Safe contracts | |||
| /// @author Richard Meissner - <[email protected]> | |||
| contract CompatibilityFallbackHandler is DefaultCallbackHandler, ISignatureValidator { | |||
| bytes4 internal constant SIMULATE_SELECTOR = bytes4(keccak256("simulate(address,bytes)")); | |||
There was a problem hiding this comment.
Why not hardcoded? It's already translated by the compiler? Then why on other places we are using the hardcoded version of a keccak256 hash
There was a problem hiding this comment.
Runtime gas costs are not affected only the deployment gas costs ... and I did not care about them here (as the contract is far from the limit). This way it would be easier to adjust if necessary.
| @@ -3,7 +3,7 @@ pragma solidity >=0.7.0 <0.9.0; | |||
|
|
|||
| import "../handler/HandlerContext.sol"; | |||
| contract TestHandler is HandlerContext { | |||
| function dudududu() external returns (address sender, address manager) { | |||
| function dudududu() external view returns (address sender, address manager) { | |||
There was a problem hiding this comment.
de da da da
Uxio0
pushed a commit
that referenced
this pull request
May 6, 2021
Saw-mon-and-Natalie
pushed a commit
to Saw-mon-and-Natalie/safe-contracts
that referenced
this pull request
Nov 1, 2023
fdarian
pushed a commit
to fdarian/safe-contracts
that referenced
this pull request
Jan 14, 2024
Support CreateCall contract library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simulateDelegatecallintoCompatibilityFallbackHandler