Add support for Dmaker.fan.p39 #1784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Landrash and thanks for the PR! Which mode is not supported (siid and piid?) when using the genericmiot? Looking at the linked spec file, the mode seems to be there. |
|
I'm incorrect. I'll close this. Should I make another pr just to the Readme adding it being supported by the genericmiiot? |
|
Ah, thanks for letting me know! No need to add it to the readme as the genericmiot should cover all modern devices :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for fanmiot p39. Already supported by genericmiot but does not expose mode.
Compared to P33 there's a few changes.
Changes
Added to README and to fan_miot.py
Source
https://miot-spec.org/miot-spec-v2/instance?type=urn:miot-spec-v2:device:fan:0000A005:dmaker-p39:1
Function test
Tested each command and function with
miioclimiiocli fanmiot --ip 10.20.30.50 --token 000000000000000000000000 COMMAND