Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for dmaker.fan.p39 #1768

Open
JoeTN opened this issue Apr 21, 2023 · 4 comments
Open

add support for dmaker.fan.p39 #1768

JoeTN opened this issue Apr 21, 2023 · 4 comments

Comments

@JoeTN
Copy link

JoeTN commented Apr 21, 2023

Would be great to have support for:

Device information:

Model: dmaker.fan.p39
Hardware version: RTL8720C
Firmware version: 2.0.5

@iwconfig
Copy link

It has already been requested in #1544 and I think already added as a generic device with #1581

But i'm not sure it works as expected so I'm chiming in here with an error message I want to get rid of:

2023-04-26 16:34:54.214 WARNING (SyncWorker_1) [miio.miot_device] Unable to find mapping for dmaker.fan.p39, falling back to dmaker.fan.p9
2023-04-26 16:34:54.498 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/lib/python3.10/site-packages/homeassistant/helpers/update_coordinator.py", line 193, in _handle_refresh_interval
    await self._async_refresh(log_failures=True, scheduled=True)
  File "/usr/lib/python3.10/site-packages/homeassistant/helpers/update_coordinator.py", line 341, in _async_refresh
    self.async_update_listeners()
  File "/usr/lib/python3.10/site-packages/homeassistant/helpers/update_coordinator.py", line 142, in async_update_listeners
    update_callback()
  File "/usr/lib/python3.10/site-packages/homeassistant/components/xiaomi_miio/fan.py", line 1085, in _handle_coordinator_update
    self._preset_mode = self.coordinator.data.mode.name
  File "/usr/lib/python3.10/site-packages/miio/integrations/fan/dmaker/fan_miot.py", line 153, in mode
    return OperationMode[OperationModeMiot(self.data["mode"]).name]
  File "/usr/lib/python3.10/enum.py", line 385, in __call__
    return cls.__new__(cls, value)
  File "/usr/lib/python3.10/enum.py", line 710, in __new__
    raise ve_exc
ValueError: None is not a valid OperationModeMiot

I could be wrong but I suspect it is related.

@JoeTN
Copy link
Author

JoeTN commented Apr 26, 2023

Got the same error, so it could be related.

@sicardf
Copy link

sicardf commented May 31, 2023

Hey 👋

I made a configuration with dmaker.fan.p11 specification in HASS. All operation except oscillation angle change 🙃

Capture d’écran 2023-05-31 à 13 46 23

@Landrash
Copy link

Added support in #1784 even tough there's support with genericmiot in #1581.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants