feat: adds support for M1 macbooks to curl installer #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/m1-curl-installer
branch
from
3720de9 to
af469f7
Compare
EverlastingBugstopper
force-pushed
the
avery/m1-curl-installer
branch
from
af469f7 to
cd8d474
Compare
|
Wouldn't it be preferable to just pre-build for M1? That's quite doable now (though it may require switching to GitHub Actions a la #947). See for example the commit adding support for Arm Mac builds on Volta. |
|
this would be the easiest lift right now with minimal changes to the code. github actions also only supports macos-11 for preview builds, so switching to github actions at this time is not feasible. unfortunately i think that by default, big sur requires that binaries be signed or they'll be SIGKILLed by gateway. i haven't included that work in this PR. |
|
should merge #1000 instead of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
M1 macbooks can run x86_64 code in emulation mode! this PR adds support for detecting if a machine is an M1 macbook, and then directs them towards the x86_64-apple-darwin binary in both the curl installer and the npm installer :)