Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "no pre-built binaries" error for aarch64, use x86_64 via rosetta #1000

Closed
wants to merge 3 commits into from

Conversation

nilslice
Copy link

@nilslice nilslice commented Apr 21, 2021

Adds support for installing binary deps (wasm-opt, etc) on a aarch64-apple-darwin target, via usage of the x86_64 binary run through the Apple-provided Rosetta instruction translator. As long as Rosetta 2 is installed on the target Apple device, all downloaded binaries will be executed using it automatically.

More info on Rosetta 2: https://support.apple.com/en-us/HT211861

closes: #952


  • You have the latest version of rustfmt installed
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

@nilslice
Copy link
Author

looks like appveyor ci check is failing here:

stderr=```[INFO]: Installing cargo-generate...
error: the `--vers` provided, `latest`, is not a valid semver version: cannot parse 'latest' as a semver
Error: Installing cargo-generate with cargo
Caused by: failed to execute `cargo install`: exited with exit code: 101
  full command: "cargo" "install" "--force" "cargo-generate" "--version" "latest" "--root" "C:\\projects\\wasm-pack-071k0\\target\\test_cache\\.cargo-generate-cargo-install-latest"

doesn't like "latest" as a version, so we may need to pull the semver compliant version.

@nilslice
Copy link
Author

In a different failing test, an attempt is made to download a pre-built binary at this URL:
https://github.com/ashleygwilliams/cargo-generate/releases/download/v0.6.1/cargo-generate-v0.6.1-x86_64-pc-windows-msvc.tar (which would be redirected to the new org cargo-generate)

The issue is that releases haven't contained these assets since Sept. 2020 (v0.5.1, https://github.com/cargo-generate/cargo-generate/tags)

Was there a reason builds were excluded from the releases since then?

@nilslice nilslice closed this Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add check for Apple Silicon Macs
1 participant