Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alexcrichton log #491

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Alexcrichton log #491

merged 3 commits into from
Jan 15, 2019

Conversation

ashleygwilliams
Copy link
Member

@ashleygwilliams ashleygwilliams commented Jan 14, 2019 •
edited
Loading

fixes #465

@ashleygwilliams ashleygwilliams mentioned this pull request Jan 14, 2019
Closed
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Jan 14, 2019
alexcrichton and others added 3 commits January 14, 2019 20:33
@alexcrichton @ashleygwilliams
Replace slog with log
c4c3b9e 
This commit replaces the `slog` family of crates used by `wasm-pack`
with the `log` crate plus `env_logger`. This also means that by default
`wasm-pack` also won't create a `wasm-pack.log` file in the current
directory. Enabling logging will now be done through
`RUST_LOG=wasm_pack` instead of `-v` flags.

Closes #425
@ashleygwilliams
doc(logs): document env_logger setup
1e3de30
@ashleygwilliams
feat(test): remove windows output fmting test
b2d75ec
@ashleygwilliams ashleygwilliams merged commit a1eeb3b into master Jan 15, 2019
@ashleygwilliams ashleygwilliams deleted the alexcrichton-log branch January 15, 2019 02:24
@huangjj27
Copy link
Member

Does that mean I need to rewrite the test？

@ashleygwilliams
Copy link
Member Author

hey @huangjj27 - i think no, at least for the moment- the way we're doing things with logs now i think it'd be pretty hard to test this. we definitely need a better solution for testing CLI output, but there's some foundational work to do that before we can rewrite this test. i'm also sad about losing it but i do think this logging strategy is the right way forward, and so perhaps for the next release we can sort a way to more robustly test the tool's output. sorry and thank you so much for your diligence!

@huangjj27
Copy link
Member

@ashleygwilliams Ok. What else can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

wasm-pack.log shouldn't be outputted if no error happened
3 participants
@ashleygwilliams @huangjj27 @alexcrichton