Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm-pack.log shouldn't be outputted if no error happened #465

Closed
drager opened this issue Dec 19, 2018 · 5 comments · Fixed by #491
Closed

wasm-pack.log shouldn't be outputted if no error happened #465

drager opened this issue Dec 19, 2018 · 5 comments · Fixed by #491
Labels
changelog - fix
Milestone
0.6.0

Comments

@drager
Copy link
Member

drager commented Dec 19, 2018

🐛 Bug description

When running wasm-pack build I get an empty wasm-pack.log file.

🤔 Expected Behavior

I expect to not get any log file if no error occurred and I expect to not get an empty one.

👟 Steps to reproduce

Follow all the steps here: https://github.com/rustwasm/wasm-pack#-quickstart-guide and then run wasm-pack build.

🌍 Your environment

Include the relevant details of your environment.
wasm-pack version: 0.5.1
rustc version: rustc 1.31.0 (abe02cefd 2018-12-04)
@ashleygwilliams ashleygwilliams added enhancement New feature or request to-do stuff that needs to happen, so plz do it k thx PR welcome labels Dec 21, 2018
@ashleygwilliams
Copy link
Member

strong agree @drager ! i would happily take a PR for this :) good call and thanks for filing!

@drager
Copy link
Member Author

drager commented Dec 21, 2018

Absolutely, I can make a PR :)

@drager
Copy link
Member Author

drager commented Dec 28, 2018

I think this issue wont be relevant once #434 is merged. If I interpret that PR correctly? @alexcrichton

@alexcrichton
Copy link
Contributor

Indeed!

@ashleygwilliams ashleygwilliams added PR attached there's a PR open for this issue and removed PR welcome labels Jan 2, 2019
@ashleygwilliams
Copy link
Member

cool- i'll work on the merge conflict for that and get it ready for the 0.6.0 release

@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Jan 2, 2019
@ashleygwilliams ashleygwilliams added changelog - fix and removed PR attached there's a PR open for this issue enhancement New feature or request to-do stuff that needs to happen, so plz do it k thx labels Jan 11, 2019
@ashleygwilliams ashleygwilliams mentioned this issue Jan 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
changelog - fix
Projects
None yet
Milestone
0.6.0
Development

Successfully merging a pull request may close this issue.

Alexcrichton log rustwasm/wasm-pack
3 participants
@alexcrichton @ashleygwilliams @drager