-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle intrinsics with constraints in the test tool. #1237
Handle intrinsics with constraints in the test tool. #1237
Conversation
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
missing.txt contains a list of intrinsics that can't be tested. Line 1-26 don't appear to exist in clang++-14 for me. I'm expecting CI to fail due to differences, patches to follow to address those. |
Is there any reason not to use the current ACLE head as a submodule, instead of one a week old? There are a few updates to A32 support in the CSV. |
@@ -0,0 +1,3 @@ | |||
[submodule "crates/intrinsic-test/acle"] | |||
path = crates/intrinsic-test/acle | |||
url = https://github.com/ARM-software/acle.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference this submodule is currently ~10MB.
This is good. There are some inconsistencies in the spreadsheet. I think we can use this list to track the missing instructions |
@pthariensflame No reason for using that version of the ACLE, it was just when I added the submodule. From looking at the changes they wouldn't impact this tool as we are only testing on the aarch64-unknown-linux-gnu target so A32 isn't touched, and we don't actually use the column that the changes were in. |
LGTM but there still seems to be some failing tests. |
I just opened #1246 once that has been merged I'll rebase this and then all the tests should pass. |
Rather than using the csv export from the tracking spreadsheet we now use the csv from the ACLE repository. This data contains any constraints that the intrinsic has.
680df32
to
a33194d
Compare
Rather than using the csv export from the tracking spreadsheet we now
use the csv from the ACLE repository. This data contains any
constraints that the intrinsic has.