Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize bidi character detection. #90559

Merged
merged 5 commits into from
Nov 6, 2021

Conversation

hkratz
Copy link
Contributor

@hkratz hkratz commented Nov 4, 2021

Should fix most of the performance regression of the bidi character detection (#90514), to be confirmed with a perf run.

@rust-highfive
Copy link
Collaborator

r? @davidtwco

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 4, 2021
@davidtwco
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 4, 2021
@bors
Copy link
Contributor

bors commented Nov 4, 2021

⌛ Trying commit 2d9f0e2 with merge 15f87d72a114643f5a7e23b820d34a779178782e...

@bors
Copy link
Contributor

bors commented Nov 4, 2021

☀️ Try build successful - checks-actions
Build commit: 15f87d72a114643f5a7e23b820d34a779178782e (15f87d72a114643f5a7e23b820d34a779178782e)

@rust-timer
Copy link
Collaborator

Queued 15f87d72a114643f5a7e23b820d34a779178782e with parent 4061c04, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (15f87d72a114643f5a7e23b820d34a779178782e): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.6% on incr-unchanged builds of cranelift-codegen)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 4, 2021
@hkratz
Copy link
Contributor Author

hkratz commented Nov 4, 2021

Hmm, it seems the coercions regression is not directly related to the bidi char detection in comments. I will have a look at it later.

Nevertheless I would like to see if the small modification suggested by @joshtriplett changed anything. Can I have another perf run?

@davidtwco
Copy link
Member

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 4, 2021
@bors
Copy link
Contributor

bors commented Nov 4, 2021

⌛ Trying commit a5b25a2 with merge 2502731217dc09e52ef0a0f525e0dbfd36c06733...

@joshtriplett
Copy link
Member

@borst try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Nov 4, 2021

☀️ Try build successful - checks-actions
Build commit: 2502731217dc09e52ef0a0f525e0dbfd36c06733 (2502731217dc09e52ef0a0f525e0dbfd36c06733)

@rust-timer
Copy link
Collaborator

Queued 2502731217dc09e52ef0a0f525e0dbfd36c06733 with parent 27143a9, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (2502731217dc09e52ef0a0f525e0dbfd36c06733): comparison url.

Summary: This change led to moderate relevant improvements 🎉 in compiler performance.

  • Moderate improvement in instruction counts (up to -0.6% on incr-unchanged builds of cranelift-codegen)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 4, 2021
@hkratz
Copy link
Contributor Author

hkratz commented Nov 4, 2021

I missed doc comments and literals being linted at a later stage. The new commits should reduce the performance impact as much as possible for the coercions benchmark (which is mostly string literals) as well.

@hkratz

This comment has been minimized.

@the8472
Copy link
Member

the8472 commented Nov 5, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 5, 2021
@bors
Copy link
Contributor

bors commented Nov 5, 2021

⌛ Trying commit 39110be with merge c30c6f0658052b0523208055c19f0b0a6aee18f3...

@bors
Copy link
Contributor

bors commented Nov 5, 2021

☀️ Try build successful - checks-actions
Build commit: c30c6f0658052b0523208055c19f0b0a6aee18f3 (c30c6f0658052b0523208055c19f0b0a6aee18f3)

@rust-timer
Copy link
Collaborator

Queued c30c6f0658052b0523208055c19f0b0a6aee18f3 with parent b99bd8f, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (c30c6f0658052b0523208055c19f0b0a6aee18f3): comparison url.

Summary: This change led to very large relevant improvements 🎉 in compiler performance.

  • Very large improvement in instruction counts (up to -11.6% on incr-unchanged builds of coercions)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 5, 2021
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 6, 2021

📌 Commit 39110be has been approved by davidtwco

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2021
@bors
Copy link
Contributor

bors commented Nov 6, 2021

⌛ Testing commit 39110be with merge 5ec7d1d...

@bors
Copy link
Contributor

bors commented Nov 6, 2021

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing 5ec7d1d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 6, 2021
@bors bors merged commit 5ec7d1d into rust-lang:master Nov 6, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 6, 2021
@hkratz hkratz deleted the optimize-bidi-detection branch November 6, 2021 20:35
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (5ec7d1d): comparison url.

Summary: This change led to very large relevant mixed results 🤷 in compiler performance.

  • Very large improvement in instruction counts (up to -11.6% on incr-unchanged builds of coercions)
  • Moderate regression in instruction counts (up to 0.6% on full builds of deeply-nested-async)

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants