-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize bidi character detection. #90559
Conversation
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 2d9f0e2 with merge 15f87d72a114643f5a7e23b820d34a779178782e... |
☀️ Try build successful - checks-actions |
Queued 15f87d72a114643f5a7e23b820d34a779178782e with parent 4061c04, future comparison URL. |
Finished benchmarking commit (15f87d72a114643f5a7e23b820d34a779178782e): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
Hmm, it seems the coercions regression is not directly related to the bidi char detection in comments. I will have a look at it later. Nevertheless I would like to see if the small modification suggested by @joshtriplett changed anything. Can I have another perf run? |
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit a5b25a2 with merge 2502731217dc09e52ef0a0f525e0dbfd36c06733... |
@borst try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
☀️ Try build successful - checks-actions |
Queued 2502731217dc09e52ef0a0f525e0dbfd36c06733 with parent 27143a9, future comparison URL. |
Finished benchmarking commit (2502731217dc09e52ef0a0f525e0dbfd36c06733): comparison url. Summary: This change led to moderate relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
I missed doc comments and literals being linted at a later stage. The new commits should reduce the performance impact as much as possible for the |
This comment has been minimized.
This comment has been minimized.
@bors try @rust-timer queue |
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
⌛ Trying commit 39110be with merge c30c6f0658052b0523208055c19f0b0a6aee18f3... |
☀️ Try build successful - checks-actions |
Queued c30c6f0658052b0523208055c19f0b0a6aee18f3 with parent b99bd8f, future comparison URL. |
Finished benchmarking commit (c30c6f0658052b0523208055c19f0b0a6aee18f3): comparison url. Summary: This change led to very large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR led to changes in compiler perf. @bors rollup=never |
@bors r+ |
📌 Commit 39110be has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (5ec7d1d): comparison url. Summary: This change led to very large relevant mixed results 🤷 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression |
Should fix most of the performance regression of the bidi character detection (#90514), to be confirmed with a perf run.