Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coercions perf benchmark regressed by 3% to 14% after bidi lint addition #90514

Open
pnkfelix opened this issue Nov 2, 2021 · 3 comments
Open

coercions perf benchmark regressed by 3% to 14% after bidi lint addition #90514

pnkfelix opened this issue Nov 2, 2021 · 3 comments
Assignees
@hkratz
Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-parser Area: The parsing of Rust source code to an AST C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@pnkfelix
Copy link
Member

pnkfelix commented Nov 2, 2021 •
edited by rustbot
Loading

Spawned off of #90462 (comment)

A bunch of benchmarks regressed. Its understandable to see overhead from a new on-by-default lint, especially one that operates at the lexing phase (and thus will affect a very broad range of benchmarks).

But coercions seems like it was hit particularly hard in some cases. I have to imagine we could do something to address that 14% regression to coercions check. (Note though that the biggest regressions are only on incremental builds of coercions. Full builds of coercions regressed by "only" 6.7%.)
@pnkfelix pnkfelix added I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-frontend Area: Compiler frontend (errors, parsing and HIR) A-parser Area: The parsing of Rust source code to an AST labels Nov 2, 2021
@hkratz
Copy link
Contributor

hkratz commented Nov 4, 2021

@rustbot claim

@hkratz hkratz mentioned this issue Nov 4, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Nov 6, 2021
@bors
Auto merge of rust-lang#90559 - rusticstuff:optimize-bidi-detection, …
5ec7d1d 
…r=davidtwco

Optimize bidi character detection.

Should fix most of the performance regression of the bidi character detection (rust-lang#90514), to be confirmed with a perf run.
@hkratz
Copy link
Contributor

hkratz commented Nov 8, 2021

#90559 fixes most of the performance regression so I think this issue can be closed.

@alex
Copy link
Member

alex commented Dec 31, 2024

a) It sounds like this can be closed
b) I believe it should be I-comptime, not I-slow

@workingjubilee workingjubilee added the C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkratz hkratz

Labels
A-frontend Area: Compiler frontend (errors, parsing and HIR) A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. A-parser Area: The parsing of Rust source code to an AST C-optimization Category: An issue highlighting optimization opportunities or PRs implementing such I-slow Issue: Problems and improvements with respect to performance of generated code. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alex @pnkfelix @hkratz @workingjubilee