-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function to turn Box<T> into Box<[T]> #71421
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// ignore-tidy-linelength | ||
#![feature(box_into_boxed_slice)] | ||
|
||
use std::boxed::Box; | ||
use std::fmt::Debug; | ||
fn main() { | ||
let boxed_slice = Box::new([1,2,3]) as Box<[u8]>; | ||
let _ = Box::into_boxed_slice(boxed_slice); | ||
//~^ ERROR the size for values of type `[u8]` cannot be known at compilation time | ||
//~^^ ERROR the size for values of type `[u8]` cannot be known at compilation time | ||
let boxed_trait: Box<dyn Debug> = Box::new(5u8); | ||
let _ = Box::into_boxed_slice(boxed_trait); | ||
//~^ ERROR the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time | ||
//~^^ ERROR the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
error[E0277]: the size for values of type `[u8]` cannot be known at compilation time | ||
--> $DIR/box-into-boxed-slice-fail.rs:8:35 | ||
| | ||
LL | let _ = Box::into_boxed_slice(boxed_slice); | ||
| ^^^^^^^^^^^ doesn't have a size known at compile-time | ||
| | ||
= help: the trait `std::marker::Sized` is not implemented for `[u8]` | ||
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait> | ||
= note: required by `std::boxed::Box::<T>::into_boxed_slice` | ||
|
||
error[E0277]: the size for values of type `[u8]` cannot be known at compilation time | ||
--> $DIR/box-into-boxed-slice-fail.rs:8:13 | ||
| | ||
LL | let _ = Box::into_boxed_slice(boxed_slice); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time | ||
| | ||
= help: the trait `std::marker::Sized` is not implemented for `[u8]` | ||
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait> | ||
= note: slice and array elements must have `Sized` type | ||
|
||
error[E0277]: the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time | ||
--> $DIR/box-into-boxed-slice-fail.rs:12:35 | ||
| | ||
LL | let _ = Box::into_boxed_slice(boxed_trait); | ||
| ^^^^^^^^^^^ doesn't have a size known at compile-time | ||
| | ||
= help: the trait `std::marker::Sized` is not implemented for `dyn std::fmt::Debug` | ||
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait> | ||
= note: required by `std::boxed::Box::<T>::into_boxed_slice` | ||
|
||
error[E0277]: the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time | ||
--> $DIR/box-into-boxed-slice-fail.rs:12:13 | ||
| | ||
LL | let _ = Box::into_boxed_slice(boxed_trait); | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time | ||
| | ||
= help: the trait `std::marker::Sized` is not implemented for `dyn std::fmt::Debug` | ||
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait> | ||
= note: slice and array elements must have `Sized` type | ||
|
||
error: aborting due to 4 previous errors | ||
|
||
For more information about this error, try `rustc --explain E0277`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
// run-pass | ||
#![feature(box_into_boxed_slice)] | ||
|
||
use std::boxed::Box; | ||
fn main() { | ||
assert_eq!(Box::into_boxed_slice(Box::new(5u8)), Box::new([5u8]) as Box<[u8]>); | ||
assert_eq!(Box::into_boxed_slice(Box::new([25u8])), Box::new([[25u8]]) as Box<[[u8; 1]]>); | ||
let a: Box<[Box<[u8; 1]>]> = Box::into_boxed_slice(Box::new(Box::new([5u8]))); | ||
let b: Box<[Box<[u8; 1]>]> = Box::new([Box::new([5u8])]); | ||
assert_eq!(a, b); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment doesn't match the code.
*mut T
≠*mut [T]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That comment is justifying the cast to an array of length 1. The slice comes after.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What justifies the subsequent cast?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's just unsizing, but we could leave that out and let the
Box<[T; 1]>
implicitly coerce unsized in the return.