Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to turn Box<T> into Box<[T]> #71421

Merged
merged 2 commits into from
Apr 26, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add success and fail tests for into_boxed_slice
  • Loading branch information
elichai committed Apr 26, 2020
commit 0228ca0c7d07f92d449209fa2eeda9eb72e68f63
15 changes: 15 additions & 0 deletions src/test/ui/box-into-boxed-slice-fail.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// ignore-tidy-linelength
#![feature(box_into_boxed_slice)]

use std::boxed::Box;
use std::fmt::Debug;
fn main() {
let boxed_slice = Box::new([1,2,3]) as Box<[u8]>;
let _ = Box::into_boxed_slice(boxed_slice);
//~^ ERROR the size for values of type `[u8]` cannot be known at compilation time
//~^^ ERROR the size for values of type `[u8]` cannot be known at compilation time
let boxed_trait: Box<dyn Debug> = Box::new(5u8);
let _ = Box::into_boxed_slice(boxed_trait);
//~^ ERROR the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time
//~^^ ERROR the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time
}
43 changes: 43 additions & 0 deletions src/test/ui/box-into-boxed-slice-fail.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
error[E0277]: the size for values of type `[u8]` cannot be known at compilation time
--> $DIR/box-into-boxed-slice-fail.rs:8:35
|
LL | let _ = Box::into_boxed_slice(boxed_slice);
| ^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `std::marker::Sized` is not implemented for `[u8]`
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
= note: required by `std::boxed::Box::<T>::into_boxed_slice`

error[E0277]: the size for values of type `[u8]` cannot be known at compilation time
--> $DIR/box-into-boxed-slice-fail.rs:8:13
|
LL | let _ = Box::into_boxed_slice(boxed_slice);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `std::marker::Sized` is not implemented for `[u8]`
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
= note: slice and array elements must have `Sized` type

error[E0277]: the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time
--> $DIR/box-into-boxed-slice-fail.rs:12:35
|
LL | let _ = Box::into_boxed_slice(boxed_trait);
| ^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `std::marker::Sized` is not implemented for `dyn std::fmt::Debug`
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
= note: required by `std::boxed::Box::<T>::into_boxed_slice`

error[E0277]: the size for values of type `dyn std::fmt::Debug` cannot be known at compilation time
--> $DIR/box-into-boxed-slice-fail.rs:12:13
|
LL | let _ = Box::into_boxed_slice(boxed_trait);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
|
= help: the trait `std::marker::Sized` is not implemented for `dyn std::fmt::Debug`
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
= note: slice and array elements must have `Sized` type

error: aborting due to 4 previous errors

For more information about this error, try `rustc --explain E0277`.
11 changes: 11 additions & 0 deletions src/test/ui/box-into-boxed-slice.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
// run-pass
#![feature(box_into_boxed_slice)]

use std::boxed::Box;
fn main() {
assert_eq!(Box::into_boxed_slice(Box::new(5u8)), Box::new([5u8]) as Box<[u8]>);
assert_eq!(Box::into_boxed_slice(Box::new([25u8])), Box::new([[25u8]]) as Box<[[u8; 1]]>);
let a: Box<[Box<[u8; 1]>]> = Box::into_boxed_slice(Box::new(Box::new([5u8])));
let b: Box<[Box<[u8; 1]>]> = Box::new([Box::new([5u8])]);
assert_eq!(a, b);
}