Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore win_delete_self test in Miri #136805

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

RalfJung
Copy link
Member

Follow-up to #134679, fixes miri-test-libstd on Windows

Cc @ChrisDenton @Mark-Simulacrum

@rustbot
Copy link
Collaborator

rustbot commented Feb 10, 2025

r? @Noratrieb

rustbot has assigned @Noratrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 10, 2025
@Noratrieb
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 10, 2025

📌 Commit 2f3c943 has been approved by Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
…kingjubilee

Rollup of 12 pull requests

Successful merges:

 - rust-lang#136053 (coverage: Defer part of counter-creation until codegen)
 - rust-lang#136201 (Removed dependency on the field-offset crate, alternate approach)
 - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix)
 - rust-lang#136353 (fix(libtest): Enable Instant on Emscripten targets)
 - rust-lang#136472 ([`compiletest`-related cleanups 2/7] Feed stage number to compiletest directly)
 - rust-lang#136487 (ci: stop mysql before removing it)
 - rust-lang#136552 (Use an `Option` for `FindNextFileHandle` in `ReadDir` instead of `INVALID_FILE_HANDLE` sentinel value)
 - rust-lang#136705 (Some miscellaneous edition-related library tweaks)
 - rust-lang#136707 (Bump `cc` to v1.2.13 for the compiler workspace)
 - rust-lang#136790 (Git blame ignore recent formatting commit)
 - rust-lang#136792 (Don't apply editorconfig to llvm)
 - rust-lang#136805 (ignore win_delete_self test in Miri)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
Rollup merge of rust-lang#136805 - RalfJung:miri-win-delete-self, r=Noratrieb

ignore win_delete_self test in Miri

Follow-up to rust-lang#134679, fixes miri-test-libstd on Windows

Cc `@ChrisDenton` `@Mark-Simulacrum`
@bors bors merged commit ffa8a96 into rust-lang:master Feb 10, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 10, 2025
@RalfJung RalfJung deleted the miri-win-delete-self branch February 10, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants