Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: stop mysql before removing it #136487

Merged
merged 1 commit into from
Feb 10, 2025
Merged

ci: stop mysql before removing it #136487

merged 1 commit into from
Feb 10, 2025

Conversation

marcoieni
Copy link
Member

Disable mysql before removing it from the runner.

This error happened in #136454 (comment)

try-job: aarch64-gnu

@rustbot
Copy link
Collaborator

rustbot commented Feb 3, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@marcoieni
Copy link
Member Author

@bors try

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 3, 2025
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
@bors
Auto merge of rust-lang#136487 - marcoieni:disable-mysql-systemctl, r…
c636b9b 
…=<try>

ci: disable mysql before removing it

try-job: aarch64-gnu
@bors
Copy link
Contributor

bors commented Feb 3, 2025

⌛ Trying commit 83b3efa with merge c636b9b...

@marcoieni marcoieni mentioned this pull request Feb 3, 2025
Merged
@RalfJung
Copy link
Member

RalfJung commented Feb 3, 2025

I don't see why systemd stopping mysql should work any better when run before apt rather than during apt 🤷 but it can't really hurt either.

@RalfJung
Copy link
Member

RalfJung commented Feb 3, 2025 •
edited
Loading

But note that systemctl disable does not stop mysql! It just disables automatically starting mysql on system boot, but we don't reboot so that does not matter. So this PR makes little sense to me.

@Kobzol
Copy link
Contributor

Kobzol commented Feb 3, 2025

I suppose it should be stop instead of disable. But apt does the same during its execution, so hard to say. Maybe the runner is too busy during an expensive apt operation and thus it times out, doing the stop beforehand could help, in theory.

@bors
Copy link
Contributor

bors commented Feb 3, 2025

☀️ Try build successful - checks-actions
Build commit: c636b9b (c636b9b472e638498ee2eea1d50c8a20c9733b66)

@marcoieni
Copy link
Member Author

I found the solution here, I'll edit this PR to do the stop 👍

@marcoieni marcoieni changed the title ci: disable mysql before removing it ci: stop mysql before removing it Feb 3, 2025
@marcoieni marcoieni force-pushed the disable-mysql-systemctl branch from 83b3efa to 4677d75 Compare February 3, 2025 15:07
@RalfJung
Copy link
Member

RalfJung commented Feb 3, 2025 •
edited
Loading

That talks about a completely different error:

/usr/share/mysql-common /configure-symlinks: No such file or directory

We got a timeout. I don't know if it is a timeout of systemd talking to mysql, or a timeout of systemctl talking to systemd. But either way, I don't see any relation to that issue you referenced.

@marcoieni
Copy link
Member Author

oops, you are right, sorry 😅

@marcoieni
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Feb 3, 2025

⌛ Trying commit 4677d75 with merge e25d31c...

bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 3, 2025
@bors
Auto merge of rust-lang#136487 - marcoieni:disable-mysql-systemctl, r…
e25d31c 
…=<try>

ci: stop mysql before removing it

try-job: aarch64-gnu
@bors
Copy link
Contributor

bors commented Feb 3, 2025

☀️ Try build successful - checks-actions
Build commit: e25d31c (e25d31c4249aacc0e29b846d301bec54a60eb652)

@marcoieni
Copy link
Member Author

@rustbot ready

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

Seems fine, I guess.

@bors
Copy link
Contributor

bors commented Feb 9, 2025

📌 Commit 4677d75 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 10, 2025
@Zalathar
Rollup merge of rust-lang#136487 - marcoieni:disable-mysql-systemctl,…
fff8baa 
… r=Mark-Simulacrum

ci: stop mysql before removing it

try-job: aarch64-gnu
@Zalathar Zalathar mentioned this pull request Feb 10, 2025
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
@bors
Auto merge of rust-lang#136804 - Zalathar:rollup-o3nyapl, r=Zalathar
9eea580 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#134626 (Add Four Codegen Tests)
 - rust-lang#136053 (coverage: Defer part of counter-creation until codegen)
 - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix)
 - rust-lang#136487 (ci: stop mysql before removing it)
 - rust-lang#136790 (Git blame ignore recent formatting commit)
 - rust-lang#136803 (Subtree update of `rust-analyzer`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
@bors
Auto merge of rust-lang#136804 - Zalathar:rollup-o3nyapl, r=
f072cf0 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#134626 (Add Four Codegen Tests)
 - rust-lang#136053 (coverage: Defer part of counter-creation until codegen)
 - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix)
 - rust-lang#136487 (ci: stop mysql before removing it)
 - rust-lang#136790 (Git blame ignore recent formatting commit)
 - rust-lang#136803 (Subtree update of `rust-analyzer`)

r? `@ghost`
`@rustbot` modify labels: rollup
@workingjubilee workingjubilee mentioned this pull request Feb 10, 2025
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
@bors
Auto merge of rust-lang#136809 - workingjubilee:rollup-jk0pew1, r=wor…
8c04e39 
…kingjubilee

Rollup of 12 pull requests

Successful merges:

 - rust-lang#136053 (coverage: Defer part of counter-creation until codegen)
 - rust-lang#136201 (Removed dependency on the field-offset crate, alternate approach)
 - rust-lang#136228 (Simplify Rc::as_ptr docs + typo fix)
 - rust-lang#136353 (fix(libtest): Enable Instant on Emscripten targets)
 - rust-lang#136472 ([`compiletest`-related cleanups 2/7] Feed stage number to compiletest directly)
 - rust-lang#136487 (ci: stop mysql before removing it)
 - rust-lang#136552 (Use an `Option` for `FindNextFileHandle` in `ReadDir` instead of `INVALID_FILE_HANDLE` sentinel value)
 - rust-lang#136705 (Some miscellaneous edition-related library tweaks)
 - rust-lang#136707 (Bump `cc` to v1.2.13 for the compiler workspace)
 - rust-lang#136790 (Git blame ignore recent formatting commit)
 - rust-lang#136792 (Don't apply editorconfig to llvm)
 - rust-lang#136805 (ignore win_delete_self test in Miri)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e1bd25e into rust-lang:master Feb 10, 2025
7 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 10, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 10, 2025
@rust-timer
Unrolled build for rust-lang#136487
7a1b765 
Rollup merge of rust-lang#136487 - marcoieni:disable-mysql-systemctl, r=Mark-Simulacrum

ci: stop mysql before removing it

try-job: aarch64-gnu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.86.0
Development

Successfully merging this pull request may close these issues.
6 participants
@marcoieni @rustbot @bors @RalfJung @Kobzol @Mark-Simulacrum