Subtree update of `rust-analyzer` #136117

lnicola · 2025-01-27T07:44:30Z

internal: Move dual blanket impl logic from source analyzer to goto_def

This time, when completing the keyword (e.g. `fn` + whitespace). The bug was actually a double-bug: First, we did not resolve the impl in the macro-expanded file but in the real file, which of course cannot work. Second, in analysis the whitespace was correlated with the `impl` and not the incomplete `fn`, which caused fake (where we insert an identifier after the whitespace) and real expansions to go out of sync, which failed analysis. The fix is to skip whitespaces in analysis.

fix: Only refresh syntax tree view when the active document changes

fix: Fix missing upmapping in trait impls completion

internal: Cleanup `Name` string rendering

Goto `Display::fmt` when invoked on `to_string`

…er_of_two

…t don't I don't think my ranking is perfect, because it places them even behind snippet completions, but this is something.

fix: Sort completion items that skip `await` and `iter()` behind those that don't

… them

If the user doesn't have rustc on $PATH, rust-analyzer won't be able to run `rustc --print cfg`. This isn't really an error, as rust-analyzer can still proceed without it. This is particularly noticeable when loading crates defined in a rust-project.json. Until the configuration is loaded, the opened files are briefly treated as detached files and users see this error. Environments with rust-project.json generally have a sysroot and rustc elsewhere, so the error confuses users.

Ensure that all the fields that rust-analyzer understands are in the manual, they all have doc comments, and they use consistent punctuation (`;` rather than mixing `,` and `;`). Whilst we're here, fix the `sysroot_src` example and add 2024 as a legal value for Rust edition.

manual: Document all rust-project.json fields

The limit was introduced in rust-lang/rust-analyzer#1408 (comment) to avoid infinite cycles but it effectively caps the number of derefs to 10. Types like `ID3D12Device14` from the `windows` crate run into this because it derefs to `ID3D12Device13`, 13 to 12 and so on. Increasing it to 20 is a quick fix; a better cycle detection method would be nicer long term.

increase `AUTODEREF_RECURSION_LIMIT` to 20

minor: Rephrase comment

Update outdated permissions section in the README.md

rustbot · 2025-01-27T07:44:35Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

lnicola · 2025-01-27T08:12:39Z

@bors r+ p=1 subtree sync

bors · 2025-01-27T08:12:43Z

📌 Commit a7cbe4b has been approved by lnicola

It is now in the queue for this repository.

Subtree update of `rust-analyzer` r? `@ghost`

Rollup of 6 pull requests Successful merges: - rust-lang#135876 (fix doc for std::sync::mpmc) - rust-lang#135961 (Fix 2/4 tests skipped by opt-dist) - rust-lang#136037 (Mark all NuttX targets as tier 3 target and support the standard library) - rust-lang#136098 (Downgrade `linker-warnings` to allow-by-default) - rust-lang#136110 (Miri subtree update) - rust-lang#136117 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

Subtree update of `rust-analyzer` r? ``@ghost``

Rollup of 9 pull requests Successful merges: - rust-lang#133151 (Trim extra whitespace in fn ptr suggestion span) - rust-lang#133929 (Remove -Zinline-in-all-cgus and clean up tests/codegen-units/) - rust-lang#134290 (Windows x86: Change i128 to return via the vector ABI) - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly) - rust-lang#136012 (Document powf and powi values that are always 1.0) - rust-lang#136104 (Add mermaid graphs of NLL regions and SCCs to polonius MIR dump) - rust-lang#136117 (Subtree update of `rust-analyzer`) - rust-lang#136143 (Update books) - rust-lang#136153 (Locate asan-odr-win with other sanitizer tests) r? `@ghost` `@rustbot` modify labels: rollup

Subtree update of `rust-analyzer` r? `@ghost`

bors · 2025-01-28T02:59:00Z

⌛ Testing commit a7cbe4b with merge 79c7685...

rust-log-analyzer · 2025-01-28T05:11:21Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2025-01-28T05:12:00Z

💔 Test failed - checks-actions

lnicola · 2025-01-29T05:46:22Z

@bors retry runner crash

bors · 2025-01-29T08:43:35Z

⌛ Testing commit a7cbe4b with merge 61cc3e5...

bors · 2025-01-29T11:26:12Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 61cc3e5 to master...

rust-timer · 2025-01-29T12:42:30Z

Finished benchmarking commit (61cc3e5): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.7%, secondary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	1
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.134s -> 775.532s (-0.33%)
Artifact size: 328.46 MiB -> 328.40 MiB (-0.02%)

ThouCheese and others added 30 commits January 18, 2025 19:35

Make niches into nices

4a7ec72

Fix missing upmapping in trait impls completion

8b25ab0

Move dual blanket impl logic from source analyzer to goto_def

48d17b4

Bring back goto def redirect for parse -> FromStr

4bc683d

Merge pull request rust-lang#18984 from Veykril/push-nszlmxoxyxss

ea3897b

internal: Move dual blanket impl logic from source analyzer to goto_def

Goto Display::fmt when invoked on to_string

e9b410d

fix: Only refresh syntax tree view when the active document changes

1d5af89

Merge pull request rust-lang#18989 from Giga-Bowser/syntax-tree-refresh

6291e1d

fix: Only refresh syntax tree view when the active document changes

Merge pull request rust-lang#18977 from ChayimFriedman2/fix-upmapping

0870bfb

fix: Fix missing upmapping in trait impls completion

Cleanup Name string rendering

54d1d31

Merge pull request rust-lang#18990 from Veykril/push-tqonnqxyrnsv

4b716bb

internal: Cleanup `Name` string rendering

Merge pull request rust-lang#18986 from Veykril/push-zlwvwlowpzqm

4308352

Goto `Display::fmt` when invoked on `to_string`

make large niche description more terse, switch to using u128::is_pow…

398cd2d

…er_of_two

Sort completion items that skip await and iter() behind those tha…

feb3fb5

…t don't I don't think my ranking is perfect, because it places them even behind snippet completions, but this is something.

Merge pull request rust-lang#18988 from ChayimFriedman2/iter-relevance

a238ab8

fix: Sort completion items that skip `await` and `iter()` behind those that don't

Fix Param::as_local treating closures wrong

f0f7204

switch from using leading zeros to trailing zeros

e08f6d4

remove is_pwr2

d8553c9

Make InlayHint::linked_location computation lazy

284e0cd

Keep already computed inlay hint properties instead of late resolving…

802d9d5

… them

Provide a config to control auto-insertion of await and iter()

5059c1a

Merge pull request rust-lang#18878 from Wilfred/document_build_info

fa272ed

manual: Document all rust-project.json fields

Merge pull request rust-lang#19004 from teoxoy/patch-1

3ca1066

increase `AUTODEREF_RECURSION_LIMIT` to 20

Rephrase comment

a32f64d

Merge pull request rust-lang#19009 from lnicola/dont-just-die

7ba18da

minor: Rephrase comment

Check cfg when collecting macro defs

27084a2

Merge pull request rust-lang#19035 from rust-lang/Veykril-patch-1

a7cbe4b

Update outdated permissions section in the README.md

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2025

Zalathar mentioned this pull request Jan 27, 2025

Rollup of 6 pull requests #136119

Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 27, 2025

Rollup merge of rust-lang#136117 - lnicola:sync-from-ra, r=lnicola

6f260b0

Subtree update of `rust-analyzer` r? `@ghost`

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 28, 2025

Rollup merge of rust-lang#136117 - lnicola:sync-from-ra, r=lnicola

8f2b5bc

Subtree update of `rust-analyzer` r? ``@ghost``

Zalathar mentioned this pull request Jan 28, 2025

Rollup of 9 pull requests #136165

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 28, 2025

Auto merge of rust-lang#136117 - lnicola:sync-from-ra, r=lnicola

79c7685

Subtree update of `rust-analyzer` r? `@ghost`

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 28, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 29, 2025

bors merged commit 61cc3e5 into rust-lang:master Jan 29, 2025
7 checks passed

rustbot added this to the 1.86.0 milestone Jan 29, 2025

lnicola deleted the sync-from-ra branch January 29, 2025 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subtree update of `rust-analyzer` #136117

Subtree update of `rust-analyzer` #136117

lnicola commented Jan 27, 2025

rustbot commented Jan 27, 2025

lnicola commented Jan 27, 2025

bors commented Jan 27, 2025

bors commented Jan 28, 2025

rust-log-analyzer commented Jan 28, 2025

bors commented Jan 28, 2025

lnicola commented Jan 29, 2025

bors commented Jan 29, 2025

bors commented Jan 29, 2025

rust-timer commented Jan 29, 2025

Subtree update of rust-analyzer #136117

Subtree update of rust-analyzer #136117

Conversation

lnicola commented Jan 27, 2025

rustbot commented Jan 27, 2025

lnicola commented Jan 27, 2025

bors commented Jan 27, 2025

bors commented Jan 28, 2025

rust-log-analyzer commented Jan 28, 2025

bors commented Jan 28, 2025

lnicola commented Jan 29, 2025

bors commented Jan 29, 2025

bors commented Jan 29, 2025

rust-timer commented Jan 29, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Subtree update of `rust-analyzer` #136117

Subtree update of `rust-analyzer` #136117