Rollup of 6 pull requests #136002
Closed
Rollup of 6 pull requests #136002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save linkcheck cache always
This will cause the CI build to be marked successful even if the build failed. Instead, use `if: '!cancelled()'` to always save the cache (except when the job is cancelled), even if the linkcheck failed. See https://stackoverflow.com/a/58859404 for more.
ci: Remove incorrect use of `continue-on-error`
This documents how to determine which settings are used in CI, since I see this question come up regularly. We currently don't have a great way to answer the question, but at least there is something.
* Rename `StringReader -> Lexer` * Remove deleted `Query` struct * Update some internal links
incorrect wording
Send a message to Zulip when a sync finishes
The `fill` value by default should be set to `' '` (space), but the current implementation uses `#[derive(Default)]` which sets it to `\0`
This also suppresses an irrelevant warning, to avoid having to re-bless the output snapshot.
document order of items in iterator from drain fixes rust-lang#135710
Rustc dev guide subtree update r? `@ghost`
Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
Fix `FormattingOptions` instantiation with `Default` The `fill` value by default should be set to `' '` (space), but the current implementation uses `#[derive(Default)]` which sets it to `\0`. Note that `FormattingOptions` is being released as part of 1.85 (unstable) - so this might warrant a backport to that branch. Tracking issue: rust-lang#118117 Follow up from rust-lang#118159 CC: `@EliasHolzmann` `@programmerjake` r? `@m-ou-se`
Doc difference between extend and extend_from_slice fixes rust-lang#97119
Rename test to `unresolvable-upvar-issue-87987.rs` and add some notes Extracted from rust-lang#135756. I had to figure out what this test was trying to test, so I might as well write it down for future reference.
rustbot
added
A-rustc-dev-guide
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup=never p=5 |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 24, 2025
Rollup of 6 pull requests Successful merges: - rust-lang#135728 (document order of items in iterator from drain) - rust-lang#135829 (Rustc dev guide subtree update) - rust-lang#135886 (Document purpose of closure in from_fn.rs more clearly) - rust-lang#135977 (Fix `FormattingOptions` instantiation with `Default`) - rust-lang#135983 (Doc difference between extend and extend_from_slice) - rust-lang#135985 (Rename test to `unresolvable-upvar-issue-87987.rs` and add some notes) r? `@ghost` `@rustbot` modify labels: rollup
|
#135983 is merged already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
FormattingOptionsinstantiation withDefault#135977 (FixFormattingOptionsinstantiation withDefault)unresolvable-upvar-issue-87987.rsand add some notes #135985 (Rename test tounresolvable-upvar-issue-87987.rsand add some notes)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup