Document workings of successors more clearly #135895
Open
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to fix rust-lang#135087 together with rust-lang#135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.
rustbot
added
S-waiting-on-review
joboet
added a commit
to joboet/rust
that referenced
this pull request
Jan 24, 2025
Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 28, 2025
Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 28, 2025
Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 28, 2025
Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2025
Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2025
Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
Rollup merge of rust-lang#135886 - hkBst:patch-14, r=workingjubilee Document purpose of closure in from_fn.rs more clearly partial fix for rust-lang#135087 together with rust-lang#135895
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Jan 29, 2025
Document purpose of closure in from_fn.rs more clearly partial fix for #135087 together with rust-lang/rust#135895
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #135087 together with #135886, but I am not sure if I've succeeded in adding much clarity here, so don't be shy with your comments.