Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extern_prelude check is breaking rustdoc #50561

Closed
sdroege opened this issue May 9, 2018 · 1 comment
Closed

extern_prelude check is breaking rustdoc #50561

sdroege opened this issue May 9, 2018 · 1 comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Milestone

Comments

@sdroege
Copy link
Contributor

sdroege commented May 9, 2018

See rust-lang/futures-rs#1003 (comment)

 Documenting futures-channel v0.2.1 (file:///home/travis/build/rust-lang-nursery/futures-rs/futures-channel)
error[E0658]: access to extern crates through prelude is experimental (see issue #44660)
  |
  = help: add #![feature(extern_prelude)] to the crate attributes to enable
error: Could not document `futures-channel`.
Caused by:
  process didn't exit successfully: `rustdoc --crate-name futures_channel futures-channel/src/lib.rs -o /home/travis/build/rust-lang-nursery/futures-rs/target/doc --cfg feature="default" --cfg feature="futures-core" --cfg feature="std" -L dependency=/home/travis/build/rust-lang-nursery/futures-rs/target/debug/deps --extern futures_core=/home/travis/build/rust-lang-nursery/futures-rs/target/debug/deps/libfutures_core-c5293a3c307e0c7b.rmeta` (exit code: 101)
warning: build failed, waiting for other jobs to finish...
sdroege added a commit to sdroege/futures-rs that referenced this issue May 9, 2018
@Nemo157
Copy link
Member

Nemo157 commented May 9, 2018

Here's a short summary of the issue, there's links to specific bits of source and the old log of rustdoc before extern_prelude made it fail in the linked comment above:

Have some documentation using the new [`Something`](somecrate::Something) doc links where somecrate is an extern crate but is not available in the current scope. Previously this would give a warning about it being unresolvable, now it will give an error that you must use the extern_prelude feature.

I think being able to use the extern_prelude feature in these doc links is great, it will really help with some cases where you want to refer to something in a context that doesn't actually use it. But when not using the feature doc links like these should block it from being suggested and instead treat it as a normal unresolvable path.

@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. labels Jun 9, 2018
@Mark-Simulacrum Mark-Simulacrum added this to the 1.28 milestone Jun 9, 2018
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this issue Jun 11, 2018
…r=QuietMisdreavus

Fix extern prelude failure in rustdoc

Fixes rust-lang#50561.

r? @QuietMisdreavus
bors added a commit that referenced this issue Jun 11, 2018
…reavus

Fix extern prelude failure in rustdoc

Fixes #50561.

r? @QuietMisdreavus
malikolivier added a commit to aflak-vis/aflak that referenced this issue Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Development

No branches or pull requests

3 participants