Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for latest nightly changes to rename Pin to PinMut #1003

Merged
merged 2 commits into from
May 10, 2018

Conversation

sdroege
Copy link
Contributor

@sdroege sdroege commented May 9, 2018

Fixes #1002

@sdroege
Copy link
Contributor Author

sdroege commented May 9, 2018

The remaining failure requires adding #![feature(extern_prelude)] to the futures and futures-channel crates. But futures-channel does not even have a nightly feature right now. What to do about this?

@Nemo157
Copy link
Member

Nemo157 commented May 9, 2018

It's very annoying that it doesn't say where is trying to access a crate through the prelude. Since it's only happening while building the docs I'm guessing it's related to some link attempting to resolve through an extern crate.

Checking the last successful build shows:

warning: [futures_core::Stream] cannot be resolved, ignoring it...

which is probably this line.

This should be fixable by changing it to one of [`Stream`], [`Stream`](Stream) or [`Stream`](::futures_core::Stream).

The futures crate appears to have a lot of similar issues, judging by the warnings in the linked build.

I think this is worth opening an issue about on rust-lang/rust, during a doc build it should block the #![feature(extern_prelude)] check and just leave it as an unresolved path.

@sdroege
Copy link
Contributor Author

sdroege commented May 9, 2018

Neither of these is fixing it, I've created a ticket on rust-lang/rust. Let's handle this in a separate PR for futures then?

@Nemo157
Copy link
Member

Nemo157 commented May 9, 2018

Oh, there's one more at https://github.com/rust-lang-nursery/futures-rs/blob/62827f1776e833a948cb81582988cb7a70a8b700/futures-channel/src/mpsc/mod.rs#L336, it would be great to check if changing both fixes it for futures-channel at least to make sure my rationale above is correct.

@sdroege
Copy link
Contributor Author

sdroege commented May 9, 2018

Oh yes, changing both fixes it

@sdroege
Copy link
Contributor Author

sdroege commented May 9, 2018

The build failure in the futures crate was just transitive from futures-channel, we're good with this fortunately.

@alexcrichton alexcrichton merged commit 6810513 into rust-lang:master May 10, 2018
@sdroege
Copy link
Contributor Author

sdroege commented May 16, 2018

Could a new release be made to crates.io with this? Otherwise the version there does not work with latest nightly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants