-
Notifications
You must be signed in to change notification settings - Fork 636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for latest nightly changes to rename Pin to PinMut #1003
Conversation
The remaining failure requires adding |
It's very annoying that it doesn't say where is trying to access a crate through the prelude. Since it's only happening while building the docs I'm guessing it's related to some link attempting to resolve through an extern crate. Checking the last successful build shows:
which is probably this line. This should be fixable by changing it to one of The futures crate appears to have a lot of similar issues, judging by the warnings in the linked build. I think this is worth opening an issue about on rust-lang/rust, during a doc build it should block the |
Neither of these is fixing it, I've created a ticket on rust-lang/rust. Let's handle this in a separate PR for futures then? |
Oh, there's one more at https://github.com/rust-lang-nursery/futures-rs/blob/62827f1776e833a948cb81582988cb7a70a8b700/futures-channel/src/mpsc/mod.rs#L336, it would be great to check if changing both fixes it for |
Oh yes, changing both fixes it |
The build failure in the futures crate was just transitive from futures-channel, we're good with this fortunately. |
Could a new release be made to crates.io with this? Otherwise the version there does not work with latest nightly :) |
Fixes #1002