New lint [error_impl_error]

[Centri3]

Closes #11101

changelog: New lint [error_impl_error]

[rustbot]

r? @Jarcho

(rustbot has picked a reviewer for you, use r? to override)

[Jarcho]

This really should be restricted to types exported from the current module. Module private types have none of the listed downsides.

[Centri3]

Could be a configuration option

[bors]

☔ The latest upstream changes (presumably #10788) made this pull request unmergeable. Please resolve the merge conflicts.

[Jarcho]

I was referring to not linting only for module-private types, not crate-private types. I doubt there's any use in having a config for this as they are unusual enough as is, and importing them would be even rarer as only sub-modules could do that.

For types visible outside their own module I would still lint them as normal. If enough people want to ignore them, but still keep the lint otherwise then this can revisited, but I would rather not have a config option unless it's going to be useful.

[Centri3]

ah, yeah that would likely be rare enough that it wouldn't be too useful

[bors]

☔ The latest upstream changes (presumably #11140) made this pull request unmergeable. Please resolve the merge conflicts.

[Jarcho]

Thank you. @bors r+

[bors]

📌 Commit 19b0e84 has been approved by Jarcho

It is now in the queue for this repository.

[bors]

⌛ Testing commit 19b0e84 with merge d71fbb9...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Jarcho
Pushing d71fbb9 to master...