-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lint [bare_dos_device_names
]
#11062
Conversation
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
123ffdf
to
f0e740f
Compare
☔ The latest upstream changes (presumably #10788) made this pull request unmergeable. Please resolve the merge conflicts. |
9045dcb
to
ecabf1e
Compare
☔ The latest upstream changes (presumably #11140) made this pull request unmergeable. Please resolve the merge conflicts. |
9ea640d
to
d7a580e
Compare
☔ The latest upstream changes (presumably #11107) made this pull request unmergeable. Please resolve the merge conflicts. |
d7a580e
to
9e8e96b
Compare
☔ The latest upstream changes (presumably #11003) made this pull request unmergeable. Please resolve the merge conflicts. |
Hey this is triage, I'm closing this due to inactivity. Currently, @Centri3 sadly doesn't have the time to continue this implementation. If anyone is interested in continuing this PR, you're more than welcome to create a new PR and push it over the finish line. :D Thank you to @Centri3 and the reviewers for the time, that you already put into this! @rustbot label +S-inactive-closed -S-waiting-on-author -S-waiting-on-review |
Triaging my old PRs in case someone wants to pick them up, I don't really think the implementation needs any more work, but there is a TODO left as a question - Should we lint these specific device names? Regardless I think I'll get around to this too at some point if nobody else does |
Closes #8511
I've made this a draft as it's not quite ready yet. But whoever's randomly picked, feel free to review ^^ Everything I've left out so far and/or haven't finished is really because I didn't get enough sleep :D I've left some TODOs about the place and will likely make it a tad more general soon enough.
changelog: New lint [
bare_dos_device_names
]