Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy Book Chapter Updates Reborn: Type Checking #10605

Merged
merged 2 commits into from
Apr 8, 2023

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Apr 7, 2023

This PR adds a new chapter to the book: "Type Checking", it hasn't changed a lot from the source mainly because there wasn't many reviews on it and I haven't see a lot of things that needed a change.

Notes

changelog: Add a new "Type Checking" chapter to the book

r? @flip1995

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 7, 2023
@llogiq
Copy link
Contributor

llogiq commented Apr 8, 2023

Nice improvement!

I'm missing a way to relate or convert hir::Ty to ty::Ty, as one someone does when working with function signatures. Would you like to add a paragraph about that?

@blyxyas
Copy link
Member Author

blyxyas commented Apr 8, 2023

Would you like to add a paragraph about that

For sure!

@blyxyas blyxyas force-pushed the book-type_checking branch from 8d2f442 to 1cf6406 Compare April 8, 2023 15:15
@llogiq
Copy link
Contributor

llogiq commented Apr 8, 2023

Great! 👍

@llogiq
Copy link
Contributor

llogiq commented Apr 8, 2023

As @flip1995 seems to be busy, @bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2023

📌 Commit 1cf6406 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 8, 2023

⌛ Testing commit 1cf6406 with merge 82d71b1...

@bors
Copy link
Contributor

bors commented Apr 8, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 82d71b1 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants