Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy Book Chapter Updates Reborn: Writing tests #10596

Merged
merged 4 commits into from
Sep 2, 2023
Merged

Clippy Book Chapter Updates Reborn: Writing tests #10596

merged 4 commits into from
Sep 2, 2023

Conversation

blyxyas
Copy link
Member

@blyxyas blyxyas commented Apr 5, 2023 •
edited
Loading

This PR adds a new chapter to the book: "Writing tests". The changes have been mainly done from reviews from #9426 and some minor re-writes.

Notes

changelog: Add a new "Writing tests" chapter to the book
r? @flip1995

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 5, 2023
@blyxyas blyxyas mentioned this pull request Apr 5, 2023
Open
dswij
dswij reviewed Apr 5, 2023
View reviewed changes
book/src/development/writing_tests.md Outdated Show resolved Hide resolved
book/src/development/writing_tests.md Show resolved Hide resolved
book/src/development/writing_tests.md Outdated Show resolved Hide resolved
@bors
Copy link
Contributor

bors commented Apr 8, 2023

☔ The latest upstream changes (presumably #10605) made this pull request unmergeable. Please resolve the merge conflicts.

@blyxyas blyxyas force-pushed the book-write_tests branch from b220918 to 04ade73 Compare April 9, 2023 19:47
flip1995
flip1995 approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM overall. So I just did some cleanup (formatting) and added some documentation about ui-toml tests.

This depends on #10598 and the FIXME about this getting fixed. Until then, let's wait until the other PR is merged.

@bors
Copy link
Contributor

bors commented Apr 16, 2023

☔ The latest upstream changes (presumably #10653) made this pull request unmergeable. Please resolve the merge conflicts.

@blyxyas blyxyas force-pushed the book-write_tests branch 2 times, most recently from c4c19e1 to 140e160 Compare April 17, 2023 21:19
@bors
Copy link
Contributor

bors commented Aug 16, 2023

☔ The latest upstream changes (presumably #10595) made this pull request unmergeable. Please resolve the merge conflicts.

flip1995
flip1995 reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments. I will address them right away.

You accidentally force pushed over a commit that I added to this branch. This can be avoided with force pushing with --force-with-lease instead of -f/--force. When using --force-with-lease, the force push will only go through if you fetched the latest state of the branch.

book/src/development/writing_tests.md Outdated Show resolved Hide resolved
book/src/development/writing_tests.md Outdated Show resolved Hide resolved
book/src/development/writing_tests.md Outdated Show resolved Hide resolved
book/src/development/writing_tests.md Outdated Show resolved Hide resolved
book/src/development/writing_tests.md Outdated Show resolved Hide resolved
book/src/development/writing_tests.md Outdated Show resolved Hide resolved
@blyxyas
Copy link
Member Author

blyxyas commented Sep 2, 2023 •
edited
Loading

I'll merge this one first, when it gets merged #10598 will be mergeable without CI errors. Then we could fix that FIXME (in a later PR, currently it cannot be done as it will bug CI)

@bors r=flip1995

@bors
Copy link
Contributor

bors commented Sep 2, 2023

📌 Commit 8ee6ca0 has been approved by flip1995

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Sep 2, 2023

⌛ Testing commit 8ee6ca0 with merge aa371eb...

@bors
Copy link
Contributor

bors commented Sep 2, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing aa371eb to master...

@bors bors merged commit aa371eb into rust-lang:master Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dswij dswij dswij left review comments

@flip1995 flip1995 flip1995 approved these changes

Assignees

@flip1995 flip1995

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blyxyas @bors @flip1995 @dswij @rustbot