Fix clap by updating the facts #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wew lad |
|
That's a nice way of keeping my +/- ratio in the negatives — especially if I never add any tests ever again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clapon master is missing some.factsfiles.PR #129 added warnings to
nagremind us to refresh this dataset with up-to-date facts. Here they are.Maybe adding a smoke test could be interesting, since it's an important dataset. The
LocationInsensitivevariant runs it in 700ms on my machine (1.5s on The Ole Laptop) so maybe it wouldn't be that bad a wait oncargo test(or if not, in a test subcrate: onlycargo test --allwould run it. And CI does that as well.)