Make clap usable, add warnings on missing fact files #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
./inputs/clap-rs
dataset doesn't work on master, and fails with the rather unhelpful erroreven though this directory does exist. The problem is that some of the fact files are missing.
This PR adds a log for when facts files are missing, but still continues execution, defaulting to an empty relation.
clap
generates these now:I thought of adding empty files to the dataset to silence the warnings, but leaving them on will remind us to regenerate the clap dataset with these new relations correctly exported.