Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up terminology: step 1 — rename Region to Origin #125

Merged
merged 15 commits into from
Sep 18, 2019

Conversation

lqd
Copy link
Member

@lqd lqd commented Sep 16, 2019

A first step in cleaning up the Polonius terminology by:

  • renaming regions into origins (except in datafrog closures and datalog rules comments, for now)
  • whenever a single-letter generic type was used, using the full word instead
  • assorted cleanups in comments or leftover random bits and bobs

@lqd lqd mentioned this pull request Sep 16, 2019
@nikomatsakis
Copy link
Contributor

@lqd did you plan to add a few more commits here?

@lqd
Copy link
Member Author

lqd commented Sep 17, 2019

@nikomatsakis not necessarily in this PR, I was thinking we could the renaming step by step, merging as each step is completed, what do you think ? (e.g. if others wanted to help, and so on)

But if you prefer a single big renaming-PR I can also do that.

@nikomatsakis
Copy link
Contributor

step by step is better!

@nikomatsakis nikomatsakis merged commit a05aea4 into rust-lang:master Sep 18, 2019
@lqd lqd deleted the a_region_has_no_name branch September 18, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants