Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define the atoms #124

Merged
merged 1 commit into from
Sep 17, 2019
Merged

define the atoms #124

merged 1 commit into from
Sep 17, 2019
+74 −1

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Sep 13, 2019 •
edited
Loading

I took a stab at some names.

  • variables
  • paths (nee MovePath)
  • nodes (nee Points)
  • loans
  • origins (nee Regions)

Note that these all have a distinct first letter, should that be relevant, although I would also like to try and use written out words.

Thoughts? We can haggle on Zulip perhaps. =)

@nikomatsakis
define the atoms
3466fff 
I took a stab at some names. Not sure if I like them all.
@amandasystems
Copy link
Contributor

amandasystems commented Sep 14, 2019 •
edited
Loading

...I now understand variables. Also, this is embarrassing.

lqd
lqd approved these changes Sep 15, 2019
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lqd
Copy link
Member

lqd commented Sep 16, 2019

if everyone likes origins, I've prepared #125 to at least start The Great Renaming™

@nikomatsakis nikomatsakis merged commit 575f6d1 into rust-lang:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikomatsakis @amandasystems @lqd