Show cargo install for crates with binaries
#8883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-enhancement ✨
5 tasks
Turbo87
changed the title
cargo install for non-library cratescargo install for crates with binaries
LawnGnome
reviewed
Jun 17, 2024
LawnGnome
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
has_libandbin_namesfields to theversionEmber Data model and then uses these new fields to displaycargo installinstructions if a crate has any binaries. If the API does not expose these fields yet, or they are returned asnullbecause the crate/version has not been analyzed yet, the code will default to the current behavior of assuming the crate is a library.Related:
cargo install crate-namerather thancargo add crate-namefor binary crates #5882has_libandbin_namesfields to the versions API #8859