-
Notifications
You must be signed in to change notification settings - Fork 620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add has_lib
and bin_names
fields to the versions API
#8859
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8859 +/- ##
==========================================
+ Coverage 88.99% 89.03% +0.03%
==========================================
Files 277 277
Lines 27845 27948 +103
==========================================
+ Hits 24781 24883 +102
- Misses 3064 3065 +1 ☔ View full report in Codecov by Sentry. |
db90124
to
000d461
Compare
☔ The latest upstream changes (presumably ea2354c) made this pull request unmergeable. Please resolve the merge conflicts. |
fa2f990
to
5264735
Compare
This PR is ready for review now. The frontend part of this work will be opened in an independent PR, same for the backfilling code. |
cargo install
for non-library cratescargo install
for non-library crates
cargo install
for non-library crateshas_lib
and bin_names
fields to the versions API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the obvious caveat that we're now dependent on cargo-manifest
's target discovery working the same way as cargo
, this LGTM. (On the bright side, this is something that's easily re-backfilled later if there are any issues, and certainly not on any critical path for publishing or using crates.)
yeah, that's why I'm currently working on fixing some of the finer details of the target auto-discovery in |
…` to detect crate "products" `Manifest::complete_from_abstract_filesystem()` looks at the filesystem paths and finds implicit "products" like libraries, binaries, or examples. This data can later be stored in the database to show `cargo install` instructions for non-library crates.
#8951 has been merged, so this is now unblocked :) |
https://docs.rs/cargo-manifest/latest/cargo_manifest/struct.Manifest.html#method.complete_from_abstract_filesystem is used to find implicit libraries or binaries in the crate file.
Tasks:
cargo install
for crates with binaries #8883)Related:
cargo install crate-name
rather thancargo add crate-name
for binary crates #5882cargo install
for crates with binaries #8883