Convert seek to named fields #8260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
force-pushed
the
field-struct-seek
branch
from
0433043 to
9f57dd4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8260 +/- ##
==========================================
+ Coverage 87.75% 87.78% +0.03%
==========================================
Files 273 273
Lines 27372 27460 +88
==========================================
+ Hits 24019 24107 +88
Misses 3353 3353 ☔ View full report in Codecov by Sentry. |
eth3lbert
force-pushed
the
field-struct-seek
branch
from
e65ebc9 to
636002e
Compare
eth3lbert
force-pushed
the
field-struct-seek
branch
from
636002e to
526e785
Compare
LawnGnome
reviewed
Mar 7, 2024
Comment on lines
613
to
615
| Id{id: i32} | ||
| New{#[serde(with="ts_microseconds")] dt: chrono::NaiveDateTime, id: i32} | ||
| RecentDownloads{ downloads: Option<i64>, id: i32 } |
There was a problem hiding this comment.
This could use some manual formatting, since rustfmt obviously isn't getting in here.
There was a problem hiding this comment.
I've managed to figure out how to rustfmt can be used for this:
- we need to have valid Rust code inside the macro invocation, but the implementation was missing trailing commas for the enum variants
- it needs to be invoked as
seek!(...);instead ofseek! { ... }and apparently that enables rustfmt to format the invocation content (see https://users.rust-lang.org/t/rustfmt-skips-macro-arguments/74807/4)
I've added two commits to the PR for the above.
There was a problem hiding this comment.
Thank you for your help. I appreciate it.
Comment on lines
+578
to
+589
| let ( | ||
| Crate { | ||
| id, | ||
| updated_at, | ||
| created_at, | ||
| .. | ||
| }, | ||
| exact_match, | ||
| downloads, | ||
| recent_downloads, | ||
| rank, | ||
| ) = *record; |
There was a problem hiding this comment.
Some day I hope to be brave enough to write a let destructure like this. 😆
Turbo87
added
C-internal 🔧
Turbo87
force-pushed
the
field-struct-seek
branch
from
4dbde8c to
03eb6fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mention in commits #8244 (comment) and #8037 (comment).
This PR is best reviewed commit-by-commit.