-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic support for seek-based pagination to versions endpoint #8037
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8037 +/- ##
==========================================
+ Coverage 87.73% 87.86% +0.12%
==========================================
Files 271 272 +1
Lines 27145 27477 +332
==========================================
+ Hits 23817 24143 +326
- Misses 3328 3334 +6 ☔ View full report in Codecov by Sentry. |
Prepare for implementing pagination support for the versions endpoint.
55e555f
to
3f1a04e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small bug, and a couple of comments, but overall this looks good to me. nice work! 👍
and in case you're wondering, I've rebased the branch on the current |
…on to versions endpoint
63ea6d5
to
93e7362
Compare
feedback addressed. thanks for the review :) diff 3f1a04e90057ae7f3714bcf3e6bd165223f00710..93e73621ccaac6b05afecc8d7488858aa84ae0b9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, let's give this a try! the test changes are all additive so I'm assuming the existing functionality won't break :)
This PR is an improved implementation of #5302.
Add seek-based pagination support to versions endpoint with following:
per_page
is provided.sort
query parameter to choose either sorting bydate
orsemver
.For date sorting, we can perform sorting and pagination directly in the database. However, Heroku Postgres doesn't support the semver PG extension, so sorting and pagination for semver needs to be done on the app server.
Resolves #5292