feat!: Move to builder pattern for snippet creation #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Snippets must be created using the builder pattern
Muscraft
added
the
M-breaking-change
epage
approved these changes
Mar 9, 2024
| } | ||
|
|
||
| /// Create a [SourceAnnotation] with the given span for a [Slice] | ||
| pub fn span(&self, span: Range<usize>) -> SourceAnnotation<'a> { |
There was a problem hiding this comment.
We could generalize this to any range type. up to you
There was a problem hiding this comment.
I think this is something we could do later if asked for it
Muscraft
force-pushed
the
builder-pattern
branch
from
d0dfc51 to
5c566c0
Compare
This was referenced Mar 13, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Snippets must be created using the builder pattern
This PR makes it so that
Snippets must be created via a builder pattern, as described in #87. This should make it easier to change the internal API without making breaking changes. It also appears to help in code readability and size but that is determined by personal preference.fixes #87