Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make API more resilient to change by using Builder Pattern #87

Closed
epage opened this issue Mar 4, 2024 · 0 comments · Fixed by #91
Closed

Make API more resilient to change by using Builder Pattern #87

epage opened this issue Mar 4, 2024 · 0 comments · Fixed by #91
Labels
C-enhancement Category: enhancement M-breaking-change Meta: Implementing or merging this will introduce a breaking change

Comments

@epage
Copy link
Contributor

epage commented Mar 4, 2024

Currently, the API directly initializes structs. This makes it harder to evolve the API. We should switch to the builder pattern for creating snippets.
@epage epage added C-enhancement Category: enhancement M-breaking-change Meta: Implementing or merging this will introduce a breaking change labels Mar 4, 2024
@Muscraft Muscraft mentioned this issue Mar 9, 2024
Merged
@epage epage closed this as completed in #91 Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: enhancement M-breaking-change Meta: Implementing or merging this will introduce a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: Move to builder pattern for snippet creation Muscraft/annotate-snippets-rs
1 participant
@epage