Bump MSRV to 1.63 #709
Merged
Bump MSRV to 1.63 #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kixunil
force-pushed
the
msrv-1.63
branch
3 times, most recently
from
ccd0a2d to
99b2cdc
Compare
tcharding
previously approved these changes
Jul 24, 2024
The version 1.63 satisfies our requirements for MSRV and provides significant benefits so this commit bumps it. This commit also starts using weak dependencies.
tcharding
approved these changes
Jul 25, 2024
apoelstra
approved these changes
Jul 26, 2024
apoelstra
added a commit
that referenced
this pull request
Jul 28, 2024
939bf9e Deprecate `Message::from_digest_slice` (Martin Habovstiak) 13c5366 Use `hex_lit::hex` in tests (Martin Habovstiak) Pull request description: Closes #710 On top of #709 ACKs for top commit: apoelstra: ACK 939bf9e Tree-SHA512: 34afc2c040e84745881d8d6d250e6fbe5a42b0fcd4dc3ea01579c52948b6ab89d31eb0ffd449d322ec1fe2c7076c05e5b6343a3e1821eae62fd0c13db926f228
apoelstra
added a commit
to rust-bitcoin/rust-bitcoin
that referenced
this pull request
Jul 28, 2024
c72069e Bump MSRV to 1.63 (Martin Habovstiak) Pull request description: The version 1.63 satisfies our requirements for MSRV and provides significant benefits so this commit bumps it. This commit also starts using some advantages of the new MSRV, namely namespaced features, weak dependencies and the ability to use trait bounds in `const` context. This however does not yet migrade the `rand-std` feature because that requires a release of `secp256k1` with the same kind of change - bumping MSRV to 1.63 and removing `rand-std` in favor of weak dependency. (Accompanying PR to secp256k1: rust-bitcoin/rust-secp256k1#709 ) Suggested plan: * merge both PRs * at some point release `hashes` and `secp256k` * remove `rand-std` from `bitcoin` * release the rest of the crates ACKs for top commit: apoelstra: ACK c72069e tcharding: ACK c72069e Tree-SHA512: 0b301ef8145f01967318d3ed1c738d33e6cf9e44f835f3762122b460a536f926916dbd6ea39d6f80b4f95402cd845e924401e75427dbb0731ca5b12b4fa6915e
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version 1.63 satisfies our requirements for MSRV and provides significant benefits so this commit bumps it. This commit also starts using weak dependencies.