Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Message::from_digest_slice? #710

Closed
Kixunil opened this issue Jul 24, 2024 · 1 comment · Fixed by #712
Closed

Deprecate Message::from_digest_slice? #710

Kixunil opened this issue Jul 24, 2024 · 1 comment · Fixed by #712
Labels
1.0 Issues and PRs required or helping to stabilize the API

Comments

@Kixunil
Copy link
Collaborator

Kixunil commented Jul 24, 2024

There is from_digest method which is more straightforward for probably all use cases - any serious hash engine will output an array, not a slice/vec/whatever. And in the rare scenarios where people use hash engines with crappy API they can just call .try_into().unwrap() themselves - no need to pollute our API.

@Kixunil Kixunil added the 1.0 Issues and PRs required or helping to stabilize the API label Jul 24, 2024
@apoelstra
Copy link
Member

Yeah, not a bad idea. Especially since we expect people to mostly stop using Message conversions anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0 Issues and PRs required or helping to stabilize the API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants