Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the erroneous warn function #44

Merged
merged 5 commits into from
Feb 10, 2025
Merged

fix: remove the erroneous warn function #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c6fbfc
fix: move the warn function to warning on the core
abhimanyubabbar Feb 8, 2025
29551b4
fix: remove the erroneous log about warning
abhimanyubabbar Feb 8, 2025
b5188de
fix: added more tests for critical codepaths
abhimanyubabbar Feb 8, 2025
4a709f8
chore: updated the build
abhimanyubabbar Feb 8, 2025
95e8102
chore: remove extra warn function when mocking
abhimanyubabbar Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105040,7 +105040,6 @@ async function upsertTransformations(transformations, transformationNameToId) {
tr.language,
);
} else {
core.info(`Creating transformation: ${tr.name}`);
// create new transformer
res = await createTransformation(
tr.name,
Expand Down Expand Up @@ -105147,10 +105146,8 @@ async function compareOutput(successResults, transformationDict) {
if (!fs.existsSync(testOutputDir)) {
fs.mkdirSync(testOutputDir);
}

if (!transformationDict.hasOwnProperty(transformerVersionID)) {
core.warn(
`Transformer with version id: ${transformerVersionID} not found.`,
);
continue;
}

Expand Down
152 changes: 151 additions & 1 deletion src/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ jest.mock("./apiCalls", () => ({
jest.mock("@actions/core", () => {
const coreMock = {
info: jest.fn(),
warn: jest.fn(),
getInput: jest.fn(),
};
return coreMock;
Expand Down Expand Up @@ -266,4 +265,155 @@ describe("test and publish transformation and libraries successfully", () => {
readFile("./src/testdata/expected.json"),
); // actual file generated is as expected
});

it("should throw an error in case testing the transformations / libraries fails", async() => {
const metapath = "./src/testdata/meta.json";

getAllTransformations.mockResolvedValue({
data: {
transformations: [
{ name: "Transformation_1", id: "transformation_id_1" },
],
},
});

getAllLibraries.mockResolvedValue({
data: {
libraries: [
{ name: "getFinanceData", id: "library_id_1" },
{ name: "getUserAddress", id: "library_id_2" },
],
},
});

updateTransformation.mockResolvedValue({
data: {
id: "transformation_id_1",
versionId: "transformation_version_id_1",
},
});

updateLibrary
.mockReturnValueOnce({
data: {
id: "library_id_1",
versionId: "library_version_id_1",
},
})
.mockReturnValueOnce({
data: {
id: "library_id_2",
versionId: "library_version_id_2",
},
});

testTransformationAndLibrary.mockResolvedValue({
data: {
result: {
successTestResults: [
],
failedTestResults: [
{
id : "transformation-id",
name: "some-upstream-transformation",
error: '{"success": false, "error": "some error message"}',
}
],
},
},
});

await expect(testAndPublish(metapath)).rejects.toThrow(
"Failures occured while running tests against input events",
);
});

it ("should handle case when library is connected to transformations not managed within the workflow", async() => {
const metapath = "./src/testdata/meta.json";

getAllTransformations.mockResolvedValue({
data: {
transformations: [
{ name: "Transformation_1", id: "transformation_id_1" },
],
},
});

getAllLibraries.mockResolvedValue({
data: {
libraries: [
{ name: "getFinanceData", id: "library_id_1" },
{ name: "getUserAddress", id: "library_id_2" },
],
},
});

updateTransformation.mockResolvedValue({
data: {
id: "transformation_id_1",
versionId: "transformation_version_id_1",
},
});

updateLibrary
.mockReturnValueOnce({
data: {
id: "library_id_1",
versionId: "library_version_id_1",
},
})
.mockReturnValueOnce({
data: {
id: "library_id_2",
versionId: "library_version_id_2",
},
});

testTransformationAndLibrary.mockResolvedValue({
data: {
result: {
successTestResults: [
{
transformerVersionID: "transformation_version_id_1",
result: {
output: {
transformedEvents: [
{
revenue: 0,
price: 0,
profit: 0,
city: "Kolkata",
country: "India",
street: "330/8",
},
{
revenue: 15,
price: 20,
profit: 5,
city: "no data found",
country: "no data found",
street: "no data found",
},
],
},
},
},
{
transformerVersionID: "other_connection_transformation_version_id",
result: {
output: {
transformedEvents: [{}],
},
},
},
],
failedTestResults: [],
},
},
});

await expect(testAndPublish(metapath)).resolves.toEqual(undefined);

});

});
5 changes: 1 addition & 4 deletions src/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ async function upsertTransformations(transformations, transformationNameToId) {
tr.language,
);
} else {
core.info(`Creating transformation: ${tr.name}`);
// create new transformer
res = await createTransformation(
tr.name,
Expand Down Expand Up @@ -193,10 +192,8 @@ async function compareOutput(successResults, transformationDict) {
if (!fs.existsSync(testOutputDir)) {
fs.mkdirSync(testOutputDir);
}

if (!transformationDict.hasOwnProperty(transformerVersionID)) {
core.warn(
`Transformer with version id: ${transformerVersionID} not found.`,
);
continue;
}

Expand Down