Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the erroneous warn function #44

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

abhimanyubabbar
Copy link
Contributor

@abhimanyubabbar abhimanyubabbar commented Feb 8, 2025

Description of the change

With recent refactoring efforts on the transformations action code to improve the code coverage etc, we added a warning log using actions/core with convention as core.warn(). This was added in the release v1.1.1. Changes in the PR:

  1. This was a breaking change as the fn doesn't exist. The test covering the codepath also wasn't present at that time which resulted in the change going in undetected. This change fixes it by removing the warn log altogether.

  2. We also have added tests now for covering some of the missing paths in the action code.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (6419813) to head (95e8102).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   83.33%   89.87%   +6.54%     
==========================================
  Files           1        1              
  Lines         162      158       -4     
  Branches       34       33       -1     
==========================================
+ Hits          135      142       +7     
+ Misses         26       16      -10     
+ Partials        1        0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhimanyubabbar abhimanyubabbar changed the title fix: move the warn function to warning on the core fix: remove the erroneous warn function Feb 8, 2025
@abhimanyubabbar abhimanyubabbar merged commit b4763ec into main Feb 10, 2025
11 checks passed
@abhimanyubabbar abhimanyubabbar deleted the fix/dat-1940-log-function-fix branch February 10, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants