Remove the dependency to activesupport #2106
Conversation
templates/template.rb
Outdated
| @ruby_class_name = @ruby_full_name.demodulize | ||
| @ruby_class_name = @ruby_full_name[/[^:]+\z/] # demodulize-like | ||
| name = @ruby_full_name.gsub("::", "_") | ||
| name = name.gsub(/(^)?(_)?([A-Z](?:[A-Z]*(?=[A-Z_])|[a-z0-9]*))/) { ($1 || $2 || "_") + $3.downcase } # underscore-like | ||
| @c_function_name = if @ruby_full_name =~ /^RBS::Types/ |
There was a problem hiding this comment.
| @c_function_name = if @ruby_full_name =~ /^RBS::Types/ | |
| @c_function_name = if @ruby_full_name.start_with? 'RBS::Types' |
|
Ah nvm, it's a conditional dependency: Lines 52 to 54 in 3fc6b05 |
|
An alternative implementation is to provide the same method via a refinement. |
... by replacing `demodulize` and `underscore` with hand-written regexps.
soutaro
force-pushed
the
remove-activesupport
branch
from
ed60476 to
fa54237
Compare
|
@amomchilov Yeah, it's subtle thing... The problem is for Ruby core developers who don't install full-development setup of RBS. They often develop without bundler or maybe rubygems, so having less dependency to minimum setup for RBS makes more sense for the case. It was my fault that I didn't notice the problem when I was reviewing your initial PR. Looks like this change works good. |
... by replacing
demodulizeandunderscorewith hand-written regexps.