-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile without activesupport #2105
Conversation
Bundler nor `ruby` may be unavailable because this is a bundled-gem.
@Morriar @amomchilov The problem is having activesupport in ruby/ruby CI. Another solution would be stop using activesupport. (Doesn't look too much difficult, but avoiding |
d183c15
to
c0d6ee7
Compare
iirc correctly we only use |
Rakefile
Outdated
task :compile => "include/rbs/ruby_objs.h" | ||
task :compile => "src/constants.c" | ||
task :compile => "src/ruby_objs.c" | ||
# Rake::Task[:compile].prereqs.prepend :templates |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we don't need this anymore?
|
To avoid unexpected adding activseupport to compile environment.
c0d6ee7
to
3142166
Compare
CI in
ruby/ruby
compiles rbs-gem because it's a bundled gem. But addingactivesupport
to compile environment is not a good idea.This PR contains a few changes:
bundle exec ruby
commandline (this is in fact unrelated to activesupport)templates
task alwaysWith this PR, we can compile the extension without installing activesupport. 🎉