Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile without activesupport #2105

Merged
merged 4 commits into from
Dec 2, 2024
Merged

Conversation

soutaro
Copy link
Member

@soutaro soutaro commented Nov 29, 2024

CI in ruby/ruby compiles rbs-gem because it's a bundled gem. But adding activesupport to compile environment is not a good idea.

This PR contains a few changes:

  1. Stop hardcoding bundle exec ruby commandline (this is in fact unrelated to activesupport)
  2. Stop triggering templates task always
  3. Add generated files

With this PR, we can compile the extension without installing activesupport. 🎉

Bundler nor `ruby` may be unavailable because this is a bundled-gem.
@soutaro soutaro added this to the RBS 3.7 milestone Nov 29, 2024
@soutaro
Copy link
Member Author

soutaro commented Nov 29, 2024

@Morriar @amomchilov The problem is having activesupport in ruby/ruby CI. Another solution would be stop using activesupport. (Doesn't look too much difficult, but avoiding templates task looks easier to me.)

@soutaro soutaro force-pushed the compile-without-activesupport branch from d183c15 to c0d6ee7 Compare November 29, 2024 09:17
@Morriar
Copy link
Contributor

Morriar commented Nov 29, 2024

iirc correctly we only use activesupport for underscore and demodulize, we could copy over these methods and remove the dependency if needed.

Rakefile Outdated
task :compile => "include/rbs/ruby_objs.h"
task :compile => "src/constants.c"
task :compile => "src/ruby_objs.c"
# Rake::Task[:compile].prereqs.prepend :templates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need this anymore?

@ParadoxV5
Copy link
Contributor

iirc correctly we only use activesupport for underscore and demodulize, we could copy over these methods and remove the dependency if needed.

@soutaro soutaro force-pushed the compile-without-activesupport branch from c0d6ee7 to 3142166 Compare December 2, 2024 12:07
@soutaro soutaro added this pull request to the merge queue Dec 2, 2024
Merged via the queue into master with commit c3c9888 Dec 2, 2024
18 checks passed
@soutaro soutaro deleted the compile-without-activesupport branch December 2, 2024 12:21
@soutaro soutaro added the Released PRs already included in the released version label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Released PRs already included in the released version
Development

Successfully merging this pull request may close these issues.

3 participants