Load dependencies on -r option also #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pocke
force-pushed
the
load-dependencies-from--r-option
branch
2 times, most recently
from
94300f8 to
8123d46
Compare
pocke
force-pushed
the
load-dependencies-from--r-option
branch
from
31fd0b5 to
0e3f4d6
Compare
pocke
changed the title
pocke
commented
Jul 28, 2022
| @@ -34,16 +34,32 @@ def initialize(core_root: DEFAULT_CORE_ROOT, repository: Repository.new) | |||
| @core_root = core_root | |||
| @repository = repository | |||
|
|
|||
| @libs = [] | |||
| @libs = Set.new | |||
There was a problem hiding this comment.
It is necessary to avoid an infinite loop.
I know EnvironmentLoader also checks duplication in each_decl, but this change is also necessary to avoid an infinite loop during add phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows you to load dependency for standard libraries loaded with
-rout of the box.Problem
rbs collectionis the manager of third-party gems' RBSs. It resolves dependencies of gems/stdlibs.But it requires defining the application dependency with
rbs_collection.yaml. It means it doesn't resolve the dependencies on-r.So, we needed to resolve the dependencies manually on
-r.Solution
With this change, the dependencies are loaded automatically even if we use
-r. It uses the same way asrbs collectionbut for-r.RBS-related tools do not need to care about this PR. The dependency will be resolved without any changes for the related tools such as typeprof.