Avoid infinite loop

ruby · Jul 15, 2022 · 31fd0b5 · 31fd0b5
1 parent 8123d46
commit 31fd0b5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/rbs/environment_loader.rb b/lib/rbs/environment_loader.rb
@@ -34,7 +34,7 @@ def initialize(core_root: DEFAULT_CORE_ROOT, repository: Repository.new)
       @core_root = core_root
       @repository = repository
 
-      @libs = []
+      @libs = Set.new
       @dirs = []
     end
 
@@ -43,8 +43,9 @@ def add(path: nil, library: nil, version: nil, resolve_dependencies: true)
       when path
         dirs << path
       when library
-        libs << Library.new(name: library, version: version)
-        resolve_dependencies(library: library, version: version) if resolve_dependencies
+        if libs.add?(Library.new(name: library, version: version)) && resolve_dependencies
+          resolve_dependencies(library: library, version: version)
+        end
       end
     end
 

diff --git a/sig/environment_loader.rbs b/sig/environment_loader.rbs
@@ -40,7 +40,7 @@ module RBS
     attr_reader core_root: Pathname?
     attr_reader repository: Repository
 
-    attr_reader libs: Array[Library]
+    attr_reader libs: Set[Library]
     attr_reader dirs: Array[Pathname]
 
     # The source where the RBS comes from.