Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ruby 2.4 test run #48

Merged
merged 2 commits into from
Nov 30, 2019
Merged

Fix Ruby 2.4 test run #48

merged 2 commits into from
Nov 30, 2019

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Nov 30, 2019 •
edited
Loading

These two commits should get CI green.

Fixes #44.

@deivid-rodriguez
Fix error printing test failure
2f38ba6 
`exception_details` is not defined anywhere.

This commit fixes the following test crash in ruby 2.4

```
Error: test_assert_output_lines(TestFileUtils): NoMethodError: undefined method `exception_details' for #<TestFileUtils:0x00005556ef699178>
```

And replaces it with an actual test failure:

```
[Test::Unit::CoreAssertions::MiniTest::Assertion] exception expected, not #<NoMethodError: undefined method `full_message' for #<RuntimeError: ok>
Did you mean?  message>.
```
@deivid-rodriguez
Fix test failure under ruby 2.4
a8968f4 
`Exception#full_message` is only defined on ruby 2.5.0 and above.
@hsbt
Copy link
Member

hsbt commented Nov 30, 2019

Thanks!

@hsbt hsbt merged commit 7023824 into ruby:master Nov 30, 2019
@deivid-rodriguez
Copy link
Contributor Author

No problem!

@deivid-rodriguez deivid-rodriguez deleted the fix_2_4_ci branch December 1, 2019 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failed on ruby 2.4 or earlier
2 participants
@deivid-rodriguez @hsbt