Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failed on ruby 2.4 or earlier #44

Closed
znz opened this issue Oct 10, 2019 · 0 comments · Fixed by #48
Closed

CI failed on ruby 2.4 or earlier #44

znz opened this issue Oct 10, 2019 · 0 comments · Fixed by #48
Assignees

Comments

@znz
Copy link
Member

znz commented Oct 10, 2019

The log pointed out that exception_details is missing.
The line does not reach on 2.5 or later, but the problem exists too.
When 2.4 or earlier, undefined method `full_message' for #<RuntimeError: ok>\nDid you mean? message` raised at

err.full_message(highlight: false, order: :top)
.
It causes the test failures.

https://github.com/ruby/fileutils/runs/254688215#step:5:9

===============================================================================
Error: test_assert_output_lines(TestFileUtils): NoMethodError: undefined method `exception_details' for #<TestFileUtils:0x000055abb296cba8>
/home/runner/work/fileutils/fileutils/test/lib/core_assertions.rb:216:in `block in assert_raise'
/home/runner/work/fileutils/fileutils/test/lib/core_assertions.rb:215:in `rescue in assert_raise'
/home/runner/work/fileutils/fileutils/test/lib/core_assertions.rb:226:in `assert_raise'
/home/runner/work/fileutils/fileutils/test/fileutils/test_fileutils.rb:236:in `test_assert_output_lines'
     233:   #
     234: 
     235:   def test_assert_output_lines
  => 236:     assert_raise(MiniTest::Assertion) {
     237:       Timeout.timeout(0.5) {
     238:         assert_output_lines([]) {
     239:           Thread.current.report_on_exception = false
===============================================================================
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants