Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generative model tutorial. #22

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Conversation

twiecki
Copy link
Contributor

@twiecki twiecki commented Jul 7, 2020

Also creates a docs subdir and moves rtlive-model.ipynb into it.

@michaelosthege
Copy link
Collaborator

@twiecki in #20 we create a notebooks subdir, but I think we should have just one. What do you think is more appropriate?

@twiecki
Copy link
Contributor Author

twiecki commented Jul 8, 2020

Probably if I were to look for stand-alone docs in a repo the notebooks dir would be the first place.

@michaelosthege
Copy link
Collaborator

A few smaller suggestions:

  1. get_and_process_covidtracking_data can be replaced with get_data from Move US-specific data loading into its own module #19:
covid.data.get_data(country='us', run_date=pd.Timestamp.today())
  1. data-download (1.) can be moved far down to after the synthetic example
  2. you can add a visualization of the model:
pmodel = model.build()
pm.model_to_graphviz()
  1. ax.legend(frameon=False) looks nicer for cell 27
  2. formatting problem in the line we will model it with a probability distribution from this study30119-3/pdf)

@k-sys
Copy link

k-sys commented Jul 8, 2020

Will merge now and fix @michaelosthege 's suggestions.

@k-sys k-sys merged commit 83de032 into rtcovidlive:master Jul 8, 2020
@twiecki twiecki deleted the add_tutorial branch July 9, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants