Move US-specific data loading into its own module #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ mechanism to register data loader for any country + more tests on the data loading mechanism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data cleaning code becomes very country specific.
By separating it into a country-specific module, we can make
covid.datamore country-independent.Data-loading functions for any country can be registered. They must have compatible signatures and return a
DataFramewith multi-index[region, date]and columnspositiveandtotal.Slices of this dataframe are used as model input. Therefore all region-specific data-cleaning must be done by the loader function.
The previous US-specific functions are imported for backwards-compatibility (tests pass).
More tests are added for the new country-independent loader API.